Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(107)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: extensions/test/data/file_util/bad_icon/good-icon.png
Issue
1537473003
:
Change extension icon load errors to warnings (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix one more test add one more test
Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/browser/extensions/api/extension_action/browser_action_unittest.cc
chrome/browser/extensions/extension_action_manager_unittest.cc
chrome/browser/extensions/extension_service_test_with_install.h
chrome/browser/extensions/extension_service_test_with_install.cc
chrome/chrome_tests_unit.gypi
chrome/common/extensions/api/extension_action/action_info.h
chrome/common/extensions/api/extension_action/action_info.cc
chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc
chrome/common/extensions/manifest_tests/extension_manifests_icons_unittest.cc
chrome/test/data/extensions/api_test/browser_action/missing_icon/background.html
chrome/test/data/extensions/api_test/browser_action/missing_icon/background.js
chrome/test/data/extensions/api_test/browser_action/missing_icon/icon24.png
chrome/test/data/extensions/api_test/browser_action/missing_icon/icon38.png
chrome/test/data/extensions/api_test/browser_action/missing_icon/manifest.json
chrome/test/data/extensions/api_test/browser_action/multi_icons/background.html
chrome/test/data/extensions/api_test/browser_action/multi_icons/background.js
chrome/test/data/extensions/api_test/browser_action/multi_icons/icon19.png
chrome/test/data/extensions/api_test/browser_action/multi_icons/icon24.png
chrome/test/data/extensions/api_test/browser_action/multi_icons/icon38.png
chrome/test/data/extensions/api_test/browser_action/multi_icons/manifest.json
extensions/common/file_util.h
extensions/common/file_util.cc
extensions/common/file_util_unittest.cc
extensions/common/manifest_handler_helpers.h
extensions/common/manifest_handler_helpers.cc
extensions/common/manifest_handlers/icons_handler.cc
extensions/test/data/file_util/bad_icon/good-icon.png
extensions/test/data/file_util/bad_icon/manifest.json
extensions/utility/unpacker.cc
View side-by-side diff with in-line comments
Download patch
« extensions/common/manifest_handler_helpers.cc
('K') |
« extensions/common/manifest_handlers/icons_handler.cc
('k') |
extensions/test/data/file_util/bad_icon/manifest.json »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
« extensions/common/manifest_handler_helpers.cc
('K') |
« extensions/common/manifest_handlers/icons_handler.cc
('k') |
extensions/test/data/file_util/bad_icon/manifest.json »
('j') |
no next file with comments »
Issue 1537473003: Change extension icon load errors to warnings (Closed)
Created 5 years ago by Evan Stade
Modified 5 years ago
Reviewers: Devlin
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 29
This is Rietveld
408576698
Chromium Code Reviews
Issue 1537473003:
Change extension icon load errors to warnings (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
