extensions/test/data/file_util/bad_icon/manifest.json - Issue 1537473003: Change extension icon load errors to warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/test/data/file_util/bad_icon/manifest.json

Issue 1537473003: Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix one more test add one more test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/test/data/file_util/bad_icon/manifest.json

diff --git a/extensions/test/data/file_util/bad_icon/manifest.json b/extensions/test/data/file_util/bad_icon/manifest.json

index e3846e4cebf71d3f8e9c0369b1796f004f0981fd..27b7dac26fbb8968a7fffd77276e6c3742f42fd3 100644

--- a/extensions/test/data/file_util/bad_icon/manifest.json

+++ b/extensions/test/data/file_util/bad_icon/manifest.json

@@ -2,7 +2,9 @@

"name": "My extension with a zero-length icon",

"version": "1.0",

"icons": {

- "16": "icon.png"

+ "16": "good-icon.png",

+ "32": "missing-icon.png",

+ "64": "icon.png"

"manifest_version": 2

}