Change extension icon load errors to warnings

chrome/browser/extensions/extension_service_test_with_install.cc

Index: chrome/browser/extensions/extension_service_test_with_install.cc
diff --git a/chrome/browser/extensions/extension_service_test_with_install.cc b/chrome/browser/extensions/extension_service_test_with_install.cc
index f2cedefa8b00ba423727e93b41862fef9b5c8612..08adc82f062fc2ad93d9d9235e93c84f8c2e9cc7 100644
--- a/chrome/browser/extensions/extension_service_test_with_install.cc
+++ b/chrome/browser/extensions/extension_service_test_with_install.cc
@@ -126,6 +126,19 @@ const Extension* ExtensionServiceTestWithInstall::PackAndInstallCRX(
                            Extension::NO_FLAGS);
 }
 
+const Extension* ExtensionServiceTestWithInstall::PackAndInstallCRXWithLocation(
+    const base::FilePath& dir_path,
+    Manifest::Location location,
+    InstallState install_state) {
+  base::FilePath crx_path;

[Devlin, 2015/12/18 22:29:02]

I'd say that we should instead be currying the location to another method that
takes all the arguments rather than duplicating the logic here, but apparently
we can't because InstallCRXWithLocation doesn't do that.  Grr.  I'll fix it
later, but can you add a TODO(devlin) here?

[Evan Stade, 2015/12/19 00:02:40]

Done.

+  base::ScopedTempDir temp_dir;
+  EXPECT_TRUE(temp_dir.CreateUniqueTempDir());
+  crx_path = temp_dir.path().AppendASCII("temp.crx");
+
+  PackCRX(dir_path, base::FilePath(), crx_path);
+  return InstallCRXWithLocation(crx_path, location, install_state);
+}
+
 // Attempts to install an extension. Use INSTALL_FAILED if the installation
 // is expected to fail.
 // If |install_state| is INSTALL_UPDATED, and |expected_old_name| is