Change extension icon load errors to warnings

chrome/browser/extensions/extension_service_test_with_install.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service_test_with_install.h"
 
 #include "base/files/file_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_creator.h"
@@ skipping 108 matching lines @@
                            Extension::NO_FLAGS);
 }
 
 const Extension* ExtensionServiceTestWithInstall::PackAndInstallCRX(
     const base::FilePath& dir_path,
     InstallState install_state) {
   return PackAndInstallCRX(dir_path, base::FilePath(), install_state,
                            Extension::NO_FLAGS);
 }
 
+const Extension* ExtensionServiceTestWithInstall::PackAndInstallCRXWithLocation(
+    const base::FilePath& dir_path,
+    Manifest::Location location,
+    InstallState install_state) {
+  base::FilePath crx_path;

[Devlin, 2015/12/18 22:29:02]

I'd say that we should instead be currying the location to another method that
takes all the arguments rather than duplicating the logic here, but apparently
we can't because InstallCRXWithLocation doesn't do that.  Grr.  I'll fix it
later, but can you add a TODO(devlin) here?

[Evan Stade, 2015/12/19 00:02:40]

Done.

+  base::ScopedTempDir temp_dir;
+  EXPECT_TRUE(temp_dir.CreateUniqueTempDir());
+  crx_path = temp_dir.path().AppendASCII("temp.crx");
+
+  PackCRX(dir_path, base::FilePath(), crx_path);
+  return InstallCRXWithLocation(crx_path, location, install_state);
+}
+
 // Attempts to install an extension. Use INSTALL_FAILED if the installation
 // is expected to fail.
 // If |install_state| is INSTALL_UPDATED, and |expected_old_name| is
 // non-empty, expects that the existing extension's title was
 // |expected_old_name|.
 const Extension* ExtensionServiceTestWithInstall::InstallCRX(
     const base::FilePath& path,
     InstallState install_state,
     int creation_flags,
     const std::string& expected_old_name) {
@@ skipping 283 matching lines @@
   content::WindowedNotificationObserver observer(
       extensions::NOTIFICATION_CRX_INSTALLER_DONE,
       content::Source<extensions::CrxInstaller>(installer.get()));
 
   installer->InstallCrx(crx_path);
 
   observer.Wait();
 }
 
 }  // namespace extensions