Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: chrome/browser/extensions/extension_action_manager_unittest.cc

Issue 1537473003: Change extension icon load errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix one more test add one more test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_action_manager_unittest.cc
diff --git a/chrome/browser/extensions/extension_action_manager_unittest.cc b/chrome/browser/extensions/extension_action_manager_unittest.cc
index d040762d37393d54ca1abbaa935dc2706c9cc0fe..76c47f1ecdace7ca77bf566fb1869c91fc2ac333 100644
--- a/chrome/browser/extensions/extension_action_manager_unittest.cc
+++ b/chrome/browser/extensions/extension_action_manager_unittest.cc
@@ -75,15 +75,18 @@ scoped_refptr<Extension> ExtensionActionManagerTest::BuildExtension(
DictionaryBuilder& action,
const char* action_type) {
std::string id = base::IntToString(curr_id_++);
- scoped_refptr<Extension> extension = ExtensionBuilder()
- .SetManifest(DictionaryBuilder().Set("version", "1")
- .Set("manifest_version", 2)
- .Set("icons", extension_icons)
- .Set(action_type, action)
- .Set("name",
- std::string("Test Extension").append(id)))
- .SetID(id)
- .Build();
+ scoped_refptr<Extension> extension =
+ ExtensionBuilder()
+ .SetManifest(
+ DictionaryBuilder()
+ .Set("version", "1")
+ .Set("manifest_version", 2)
+ .Set("icons", extension_icons)
+ .Set(action_type, action)
+ .Set("name", std::string("Test Extension").append(id)))
+ .SetLocation(Manifest::UNPACKED)
+ .SetID(id)
+ .Build();
registry_->AddEnabled(extension);
return extension;
}

Powered by Google App Engine
This is Rietveld 408576698