third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 1537403003: WebGL2: add types to fix bugs for vertexAttribPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 1537403003: WebGL2: add types to fix bugs for vertexAttribPointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a small fix Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index e02dfa5b2e4daa8de10207cca12bfcfed0929638..87b8ab576d4402e062aa39696b7761e79585aac8 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -481,7 +481,7 @@ protected:

// Helper to return the size in bytes of OpenGL data types

// like GL_FLOAT, GL_INT, etc.

- unsigned sizeInBytes(GLenum type);

+ virtual unsigned sizeInBytes(GLenum type, bool isIntegerAPI) const;

Zhenyao Mo 2015/12/22 19:15:51 I don't think it's a good idea to add isIntegerAPI

yunchao 2015/12/23 00:20:38 Got it. Then I would like to remove 'isIntegerAPI'

// Check if each enabled vertex attribute is bound to a buffer.

bool validateRenderingState(const char*);