WebGL2: add types to fix bugs for vertexAttribPointer

third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 463 matching lines @@
     void destroyContext();
     void markContextChanged(ContentChangeType);
 
     // Query if the context is NPOT strict.
     bool isNPOTStrict() { return !isWebGL2OrHigher(); }
     // Query if depth_stencil buffer is supported.
     bool isDepthStencilSupported() { return m_isDepthStencilSupported; }
 
     // Helper to return the size in bytes of OpenGL data types
     // like GL_FLOAT, GL_INT, etc.
-    unsigned sizeInBytes(GLenum type);
+    virtual unsigned sizeInBytes(GLenum type, bool isIntegerAPI) const;

[Zhenyao Mo, 2015/12/22 19:15:51]

I don't think it's a good idea to add isIntegerAPI only for the purpose of an
ASSERT.  It's better we do not introduce ES3 concepts to the base class.

[yunchao, 2015/12/23 00:20:38]

Got it. Then I would like to remove 'isIntegerAPI' parameter. HALF_FLOAT,
INT_2_10_10_10_REV and UNSIGNED_INT_2_10_10_10_REV types should be checked to
generate INVALID_ENUM in vertexAttribIPointer according to WebGL spec (We have
done this already in Chromium).  

 
     // Check if each enabled vertex attribute is bound to a buffer.
     bool validateRenderingState(const char*);
 
     bool validateWebGLObject(const char*, WebGLObject*);
 
     // Adds a compressed texture format.
     void addCompressedTextureFormat(GLenum);
     void removeAllCompressedTextureFormats();
 
@@ skipping 653 matching lines @@
     static WebGLRenderingContextBase* oldestEvictedContext();
 };
 
 DEFINE_TYPE_CASTS(WebGLRenderingContextBase, CanvasRenderingContext, context, context->is3d(), context.is3d());
 
 } // namespace blink
 
 WTF_ALLOW_MOVE_INIT_AND_COMPARE_WITH_MEM_FUNCTIONS(blink::WebGLRenderingContextBase::TextureUnitState);
 
 #endif // WebGLRenderingContextBase_h