Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1537313002: Fix a crash by search event handler for <input type=search incremental>. (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Fix a crash by search event handler for <input type=search incremental>. We had a crash in SearchInputType::didSetValueByUserEdit(). Dispatching a synchronous event here is dangerous. This CL makes the non-standard 'search' event dispatching asynchronous in the following cases: - The input value becomes empty. - The form is submitted implicitly. Basically 'search' event is triggered by input value changes, and is dispatched asynchronously by a timer. So, the behavior change should be acceptable. BUG=570427 TEST=automated Review URL: https://codereview.chromium.org/1529373002 Cr-Commit-Position: refs/heads/master@{#365773} (cherry picked from commit dd6acb021e38e8181684026899fdef556099e408) Committed: https://chromium.googlesource.com/chromium/src/+/58383a4c517b802a25ccc41b2a2219332a81e5a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/onsearch-enter.html View 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/search/search-change-type-onsearch.html View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/SearchInputType.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
5 years ago (2015-12-21 00:50:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58383a4c517b802a25ccc41b2a2219332a81e5a6.

Powered by Google App Engine
This is Rietveld 408576698