Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1529373002: Fix a crash by search event handler for <input type=search incremental>. (Closed)

Created:
5 years ago by tkent
Modified:
5 years ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash by search event handler for <input type=search incremental>. We had a crash in SearchInputType::didSetValueByUserEdit(). Dispatching a synchronous event here is dangerous. This CL makes the non-standard 'search' event dispatching asynchronous in the following cases: - The input value becomes empty. - The form is submitted implicitly. Basically 'search' event is triggered by input value changes, and is dispatched asynchronously by a timer. So, the behavior change should be acceptable. BUG=570427 TEST=automated Committed: https://crrev.com/dd6acb021e38e8181684026899fdef556099e408 Cr-Commit-Position: refs/heads/master@{#365773}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/onsearch-enter.html View 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/search/search-change-type-onsearch.html View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/SearchInputType.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529373002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529373002/60001
5 years ago (2015-12-17 03:34:43 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 05:22:00 UTC) #8
tkent
kochi@, would you review this please? A typical fix for this kind of crashes is ...
5 years ago (2015-12-17 05:28:51 UTC) #10
kochi
lgtm
5 years ago (2015-12-17 07:21:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529373002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529373002/60001
5 years ago (2015-12-17 07:24:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:60001)
5 years ago (2015-12-17 07:30:23 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-17 07:31:23 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd6acb021e38e8181684026899fdef556099e408
Cr-Commit-Position: refs/heads/master@{#365773}

Powered by Google App Engine
This is Rietveld 408576698