third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp - Issue 1537133002: Renaming: distinguish ancestor, container and paintInvalidationContainer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

Issue 1537133002: Renaming: distinguish ancestor, container and paintInvalidationContainer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SelectionInvalidation

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

diff --git a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

index 0cce623aca4a2f6a709ffe755c419b137d65a82b..4c63c6a54502a3cf62174b3303b5fcd3962b7b5f 100644

--- a/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

+++ b/third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp

@@ -30,7 +30,7 @@ PaintInvalidationState::PaintInvalidationState(const LayoutView& layoutView, Vec

}

if (ownerPaintInvalidationState && ownerPaintInvalidationState->m_forcedSubtreeInvalidationWithinContainer)

m_forcedSubtreeInvalidationWithinContainer = true;

- FloatPoint point = layoutView.localToContainerPoint(FloatPoint(), &m_paintInvalidationContainer, TraverseDocumentBoundaries);

+ FloatPoint point = layoutView.localToAncestorPoint(FloatPoint(), &m_paintInvalidationContainer, TraverseDocumentBoundaries);

m_paintOffset = LayoutSize(point.x(), point.y());

}

m_clipRect = layoutView.viewRect();

@@ -62,7 +62,7 @@ PaintInvalidationState::PaintInvalidationState(PaintInvalidationState& next, Lay

} else {

if (m_cachedOffsetsEnabled) {

if (fixed) {

- FloatPoint fixedOffset = layoutObject.localToContainerPoint(FloatPoint(), &m_paintInvalidationContainer, TraverseDocumentBoundaries);

+ FloatPoint fixedOffset = layoutObject.localToAncestorPoint(FloatPoint(), &m_paintInvalidationContainer, TraverseDocumentBoundaries);

m_paintOffset = LayoutSize(fixedOffset.x(), fixedOffset.y());

} else {

LayoutSize offset = layoutObject.isBox() && !layoutObject.isTableRow() ? toLayoutBox(layoutObject).locationOffset() : LayoutSize();