third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 1537133002: Renaming: distinguish ancestor, container and paintInvalidationContainer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 1537133002: Renaming: distinguish ancestor, container and paintInvalidationContainer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SelectionInvalidation

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index 5f0e1c09483469573970f453e321b5aaa6cf92fb..9c5dfc708b03250f493d53ce53bcf6f85f5eba69 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -853,7 +853,7 @@ void CompositedLayerMapping::updateOverflowControlsHostLayerGeometry(const Paint

} else {

// The controls are in the same 2D space as the compositing container, so we can map them into the space of the container.

TransformState transformState(TransformState::ApplyTransformDirection, FloatPoint());

- m_owningLayer.layoutObject()->mapLocalToContainer(compositingStackingContext->layoutObject(), transformState, ApplyContainerFlip);

+ m_owningLayer.layoutObject()->mapLocalToAncestor(compositingStackingContext->layoutObject(), transformState, ApplyContainerFlip);

transformState.flatten();

hostLayerPosition = LayoutPoint(transformState.lastPlanarPoint());

if (PaintLayerScrollableArea* scrollableArea = compositingStackingContext->scrollableArea())

@@ -2278,7 +2278,7 @@ IntRect CompositedLayerMapping::recomputeInterestRect(const GraphicsLayer* graph

LayoutView* rootView = anchorLayoutObject->view();

while (rootView->frame()->ownerLayoutObject())

rootView = rootView->frame()->ownerLayoutObject()->view();

- anchorLayoutObject->mapToVisibleRectInContainerSpace(rootView, visibleContentRect, 0);

+ anchorLayoutObject->mapToVisibleRectInAncestorSpace(rootView, visibleContentRect, 0);

visibleContentRect.intersect(LayoutRect(rootView->frameView()->visibleContentRect()));

// Map the visible content rect from screen space to local graphics layer space.