Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1537133002: Renaming: distinguish ancestor, container and paintInvalidationContainer (Closed)

Created:
5 years ago by Xianzhu
Modified:
4 years, 11 months ago
Reviewers:
pdr., szager1, chrishtr
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kenneth.christiansen, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@SelectionInvalidation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming: distinguish ancestor, container and paintInvalidationContainer - container: should use the definition of LayoutObject::container(). - ancestor: may be container, some ancestor between this object and its container or ancestor of its container. Some places named this as 'container'. - ancestorContainer: container, or container's container or container's ancestor container. - paintInvalidationContainer: should be an actual paintInvalidationContainer used for paint invalidation. Also renamed: - LayoutBox::applyCachedScrollOffsetForPaintInvalidation() to LayoutBox::mapScrollingContentsRectToBoxSpace() - LayoutBox::applyCachedClipAndScrollOffsetForPaintInvalidation() to LayoutBox::applyOverflowClip() (scroll offset functionality is separated out) because they are not only used for paint invalidation. Committed: https://crrev.com/88719a882e81c1f008c8cbf89584a25769458a31 Cr-Commit-Position: refs/heads/master@{#367620}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -244 lines) Patch
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 11 chunks +35 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGeometryMap.cpp View 1 5 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 7 chunks +21 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 4 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 9 chunks +26 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 6 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BlockFlowPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp View 6 chunks +49 lines, -49 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
Xianzhu
5 years ago (2015-12-18 22:49:18 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537133002/20001
5 years ago (2015-12-20 00:19:44 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/95065)
5 years ago (2015-12-20 01:15:54 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537133002/20001
5 years ago (2015-12-21 17:40:27 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/158188)
5 years ago (2015-12-21 18:27:05 UTC) #14
Xianzhu
Bump
4 years, 11 months ago (2016-01-05 17:38:12 UTC) #15
chrishtr
lgtm Nice.
4 years, 11 months ago (2016-01-05 18:34:29 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1537133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1537133002/40001
4 years, 11 months ago (2016-01-05 18:35:04 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2016-01-05 20:06:38 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 20:07:31 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88719a882e81c1f008c8cbf89584a25769458a31
Cr-Commit-Position: refs/heads/master@{#367620}

Powered by Google App Engine
This is Rietveld 408576698