Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1537003002: autofill: save pasted passwords on Mac (Closed)

Created:
5 years ago by Elly Fong-Jones
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

autofill: save pasted passwords on Mac Have RenderFrames export whether they are currently handling a paste, and have autofill save text that came from a paste. Pastes are not "user gestures" in the blink sense of the phrase, but pastes via InputMsg_Paste are always user- triggered. BUG=514636 Review URL: https://codereview.chromium.org/1488093002 Cr-Commit-Position: refs/heads/master@{#363232} (cherry picked from commit db20fae16218c15f2d28adf8ce2eb79ebe774921) Committed: https://chromium.googlesource.com/chromium/src/+/75c6c910311e72118afa6e11fc14928c500eda75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -6 lines) Patch
M chrome/browser/autofill/autofill_interactive_uitest.cc View 7 chunks +62 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +5 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_test_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/renderer/render_frame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Elly Fong-Jones
5 years ago (2015-12-18 15:54:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
75c6c910311e72118afa6e11fc14928c500eda75.

Powered by Google App Engine
This is Rietveld 408576698