autofill: save pasted passwords on Mac

autofill: save pasted passwords on Mac

Have RenderFrames export whether they are currently handling a paste, and have
autofill save text that came from a paste. Pastes are not "user gestures" in
the blink sense of the phrase, but pastes via InputMsg_Paste are always user-
triggered.

BUG=514636
Committed: https://crrev.com/db20fae16218c15f2d28adf8ce2eb79ebe774921
Cr-Commit-Position: refs/heads/master@{#363232}

[Elly Fong-Jones, 2015-12-01 15:52:46]

Description was changed from

==========
autofill: save pasted passwords on Mac

Have RenderFrames export whether they are currently handling a paste, and have
autofill save text that came from a paste. Pastes are not "user gestures" in
the blink sense of the phrase, but pastes via InputMsg_Paste are always user-
triggered.

BUG=514636
==========

to

==========
autofill: save pasted passwords on Mac

Have RenderFrames export whether they are currently handling a paste, and have
autofill save text that came from a paste. Pastes are not "user gestures" in
the blink sense of the phrase, but pastes via InputMsg_Paste are always user-
triggered.

BUG=514636
==========

[Elly Fong-Jones, 2015-12-01 15:52:46]

ellyjones@chromium.org changed reviewers:
+ jochen@chromium.org

[Elly Fong-Jones, 2015-12-01 15:52:53]

jochen: ptal?

[jochen (gone - plz use gerrit), 2015-12-01 16:07:59]

can we remove the WebScopedUserGestureIndicator from
RenderFrameImpl::OnExtendSelectionAndDelete again now?

can you add a test for the new code?

[vabr (Chromium), 2015-12-01 16:10:03]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-12-01 16:10:04]

components/autofill/content/renderer/autofill_agent.cc LGTM.

Thanks for fixing this issue!

Vaclav

[Elly Fong-Jones, 2015-12-03 21:06:15]

On 2015/12/01 16:07:59, jochen wrote:
> can we remove the WebScopedUserGestureIndicator from
> RenderFrameImpl::OnExtendSelectionAndDelete again now?
> 
> can you add a test for the new code?

Done and done.

[jochen (gone - plz use gerrit), 2015-12-04 13:16:44]

lgtm

[Elly Fong-Jones, 2015-12-04 14:20:50]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2015-12-04 14:20:50]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1488093002/#ps20001
(title: "Add browser test coverage")

[commit-bot: I haz the power, 2015-12-04 14:21:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488093002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488093002/20001

[commit-bot: I haz the power, 2015-12-04 14:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 14:51:50]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elly Fong-Jones, 2015-12-04 15:13:43]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2015-12-04 15:13:43]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1488093002/#ps40001
(title: "don't always quit the runloop on text changes")

[commit-bot: I haz the power, 2015-12-04 15:14:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1488093002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1488093002/40001

[commit-bot: I haz the power, 2015-12-04 16:48:02]

Description was changed from

==========
autofill: save pasted passwords on Mac

Have RenderFrames export whether they are currently handling a paste, and have
autofill save text that came from a paste. Pastes are not "user gestures" in
the blink sense of the phrase, but pastes via InputMsg_Paste are always user-
triggered.

BUG=514636
==========

to

==========
autofill: save pasted passwords on Mac

Have RenderFrames export whether they are currently handling a paste, and have
autofill save text that came from a paste. Pastes are not "user gestures" in
the blink sense of the phrase, but pastes via InputMsg_Paste are always user-
triggered.

BUG=514636
==========

[commit-bot: I haz the power, 2015-12-04 16:48:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-04 16:49:35]

Description was changed from

==========
autofill: save pasted passwords on Mac

Have RenderFrames export whether they are currently handling a paste, and have
autofill save text that came from a paste. Pastes are not "user gestures" in
the blink sense of the phrase, but pastes via InputMsg_Paste are always user-
triggered.

BUG=514636
==========

to

==========
autofill: save pasted passwords on Mac

Have RenderFrames export whether they are currently handling a paste, and have
autofill save text that came from a paste. Pastes are not "user gestures" in
the blink sense of the phrase, but pastes via InputMsg_Paste are always user-
triggered.

BUG=514636

Committed: https://crrev.com/db20fae16218c15f2d28adf8ce2eb79ebe774921
Cr-Commit-Position: refs/heads/master@{#363232}
==========

[commit-bot: I haz the power, 2015-12-04 16:49:36]

Patchset 3 (id:??) landed as
https://crrev.com/db20fae16218c15f2d28adf8ce2eb79ebe774921
Cr-Commit-Position: refs/heads/master@{#363232}