Disable building a bunch of things that are about to break.

Disable building a bunch of things that are about to break.

The following series of patches will delete and refactor a whole
pile of stuff.  To make things easier, temporarily disable the build
for example apps that will be fixed up in subsequent patches.

BUG=

Review URL: https://codereview.chromium.org/1534683002 .

R=viettrungluu@chromium.org, abarth, jamesr, vtl

Committed: https://chromium.googlesource.com/external/mojo/+/8203347c4ba2808d66868930b198982aa126de9d

[jeffbrown, 2015-12-17 21:57:37]

Description was changed from

==========
Disable building a bunch of things that are about to break.

The following series of patches will delete and refactor a whole
pile of stuff.  To make things easier, temporarily disable the build
for example apps that will be fixed up in subsequent patches.

BUG=

Review URL: https://codereview.chromium.org/1534683002 .

R=abarth, jamesr, vtl
==========

to

==========
Disable building a bunch of things that are about to break.

The following series of patches will delete and refactor a whole
pile of stuff.  To make things easier, temporarily disable the build
for example apps that will be fixed up in subsequent patches.

BUG=

Review URL: https://codereview.chromium.org/1534683002 .

R=abarth, jamesr, vtl
==========

[jeffbrown, 2015-12-17 21:57:37]

jeffbrown@google.com changed reviewers:
+ viettrungluu@chromium.org
- vtl@google.com

[vtl, 2015-12-17 22:36:18]

vtl@google.com changed reviewers:
+ vtl@google.com

[vtl, 2015-12-17 22:36:19]

https://codereview.chromium.org/1536853002/diff/1/apps/BUILD.gn
File apps/BUILD.gn (left):

https://codereview.chromium.org/1536853002/diff/1/apps/BUILD.gn#oldcode11
apps/BUILD.gn:11: deps = [
I wonder if you should leave a TODO (and possibly even just comment things out)?

The reason for the existence of this target after the change is a bit
confusing....

(Ditto for the other file.)

[jeffbrown, 2015-12-17 22:38:01]

On 2015/12/17 22:36:19, vtl wrote:
> https://codereview.chromium.org/1536853002/diff/1/apps/BUILD.gn
> File apps/BUILD.gn (left):
> 
> https://codereview.chromium.org/1536853002/diff/1/apps/BUILD.gn#oldcode11
> apps/BUILD.gn:11: deps = [
> I wonder if you should leave a TODO (and possibly even just comment things
out)?
> 
> The reason for the existence of this target after the change is a bit
> confusing....
> 
> (Ditto for the other file.)

True, I debated that.  I even considered removing the target and adding it back
but it seemed like more trouble than it was worth.  We're likely to submit the
whole chain of dependent patches some afternoon so the confusion won't last
long.

[viettrungluu, 2015-12-17 23:06:49]

On 2015/12/17 22:38:01, jeffbrown wrote:
> On 2015/12/17 22:36:19, vtl wrote:
> > https://codereview.chromium.org/1536853002/diff/1/apps/BUILD.gn
> > File apps/BUILD.gn (left):
> > 
> > https://codereview.chromium.org/1536853002/diff/1/apps/BUILD.gn#oldcode11
> > apps/BUILD.gn:11: deps = [
> > I wonder if you should leave a TODO (and possibly even just comment things
> out)?
> > 
> > The reason for the existence of this target after the change is a bit
> > confusing....
> > 
> > (Ditto for the other file.)
> 
> True, I debated that.  I even considered removing the target and adding it
back
> but it seemed like more trouble than it was worth.  We're likely to submit the
> whole chain of dependent patches some afternoon so the confusion won't last
> long.

OK, lgtm in that case.

[jeffbrown, 2016-01-26 08:37:43]

rebase

[jeffbrown, 2016-01-26 23:46:56]

Description was changed from

==========
Disable building a bunch of things that are about to break.

The following series of patches will delete and refactor a whole
pile of stuff.  To make things easier, temporarily disable the build
for example apps that will be fixed up in subsequent patches.

BUG=

Review URL: https://codereview.chromium.org/1534683002 .

R=abarth, jamesr, vtl
==========

to

==========
Disable building a bunch of things that are about to break.

The following series of patches will delete and refactor a whole
pile of stuff.  To make things easier, temporarily disable the build
for example apps that will be fixed up in subsequent patches.

BUG=

Review URL: https://codereview.chromium.org/1534683002 .

R=viettrungluu@chromium.org, abarth, jamesr, vtl

Committed:
https://chromium.googlesource.com/external/mojo/+/8203347c4ba2808d66868930b19...
==========

[jeffbrown, 2016-01-26 23:46:58]

Committed patchset #3 (id:40001) manually as
8203347c4ba2808d66868930b198982aa126de9d (presubmit successful).