Issue 1534683002: Disable building a bunch of things that are about to break.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1534683002: Disable building a bunch of things that are about to break. (Closed)

Created:
5 years ago by jeffbrown

Modified:
5 years ago

Reviewers:

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@cl-1b

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Disable building a bunch of things that are about to break. The following series of patches will delete and refactor a whole pile of stuff. To make things easier, temporarily disable the build for example apps that will be fixed up in subsequent patches. BUG= Committed: https://chromium.googlesource.com/external/mojo/+/65c937edf853344cc6a14e6fb0221caaa09461e5

Patch Set 1 #

Patch Set 2 : rebase #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -19 lines)			Patch
	M	apps/BUILD.gn	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
	M	examples/BUILD.gn	View	1	3 chunks	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jeffbrown

Committed patchset #2 (id:20001) manually as 65c937edf853344cc6a14e6fb0221caaa09461e5.

5 years ago (2015-12-17 19:48:24 UTC) #2

jeffbrown

5 years ago (2015-12-17 19:51:55 UTC) #3

Message was sent while issue was closed.

TBRing a bunch of deletes to get things out of the way for Mozart.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages