Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 1536713005: Cleanup ChannelMultiplexer tests to avoid dependency on FakeSession. (Closed)

Created:
5 years, 1 month ago by Sergey Ulanov
Modified:
5 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@connection_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup ChannelMultiplexer tests to avoid dependency on FakeSession. Previously these tests were using FakeSession. Updated them to use FakeStreamChannelFactory. Committed: https://crrev.com/764fcbc6abb7231de62bd718e99f576cdedc91c2 Cr-Commit-Position: refs/heads/master@{#365963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -69 lines) Patch
M remoting/protocol/channel_multiplexer_unittest.cc View 10 chunks +16 lines, -47 lines 0 comments Download
M remoting/protocol/fake_stream_socket.h View 3 chunks +15 lines, -10 lines 0 comments Download
M remoting/protocol/fake_stream_socket.cc View 3 chunks +2 lines, -12 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
5 years, 1 month ago (2015-12-17 21:51:10 UTC) #2
Jamie
lgtm
5 years, 1 month ago (2015-12-17 22:25:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1536713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1536713005/1
5 years, 1 month ago (2015-12-18 00:34:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-12-18 01:21:59 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-12-18 01:23:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/764fcbc6abb7231de62bd718e99f576cdedc91c2
Cr-Commit-Position: refs/heads/master@{#365963}

Powered by Google App Engine
This is Rietveld 408576698