Replace ice_connection_to_client_unittest.cc with connection_unittest.cc

Replace ice_connection_to_client_unittest.cc with connection_unittest.cc

The new tests setup both ends of the connection, which also means
they test both ends. Previously there were no unittests for
ConnectionToHostImpl. It will also be possible to use the same tests
for WebRTC-based connections.

Committed: https://crrev.com/ba057a794e38c6c76fdc61a633d603a605caf9ce
Cr-Commit-Position: refs/heads/master@{#365948}

[Sergey Ulanov, 2015-12-17 01:24:26]

Patchset #1 (id:1) has been deleted

[Sergey Ulanov, 2015-12-17 01:25:27]

sergeyu@chromium.org changed reviewers:
+ joedow@chromium.org

[joedow, 2015-12-17 17:29:11]

lgtm

https://codereview.chromium.org/1531983002/diff/40001/remoting/protocol/conne...
File remoting/protocol/connection_unittest.cc (right):

https://codereview.chromium.org/1531983002/diff/40001/remoting/protocol/conne...
remoting/protocol/connection_unittest.cc:99: 
nit: remove extra newline

https://codereview.chromium.org/1531983002/diff/40001/remoting/protocol/fake_...
File remoting/protocol/fake_session.h (right):

https://codereview.chromium.org/1531983002/diff/40001/remoting/protocol/fake_...
remoting/protocol/fake_session.h:60: public:
not part of your change, but why is public set twice (line 42 and 60)?

Was this meant to be private?

https://codereview.chromium.org/1531983002/diff/40001/remoting/remoting_test....
File remoting/remoting_test.gypi (right):

https://codereview.chromium.org/1531983002/diff/40001/remoting/remoting_test....
remoting/remoting_test.gypi:315: 'protocol/connection_unittest.cc.cc',
duplicate file extension ".cc.cc".

[Sergey Ulanov, 2015-12-17 17:36:18]

https://codereview.chromium.org/1531983002/diff/40001/remoting/protocol/conne...
File remoting/protocol/connection_unittest.cc (right):

https://codereview.chromium.org/1531983002/diff/40001/remoting/protocol/conne...
remoting/protocol/connection_unittest.cc:99: 
On 2015/12/17 17:29:11, joedow wrote:
> nit: remove extra newline

Done.

https://codereview.chromium.org/1531983002/diff/40001/remoting/protocol/fake_...
File remoting/protocol/fake_session.h (right):

https://codereview.chromium.org/1531983002/diff/40001/remoting/protocol/fake_...
remoting/protocol/fake_session.h:60: public:
On 2015/12/17 17:29:11, joedow wrote:
> not part of your change, but why is public set twice (line 42 and 60)?
> 
> Was this meant to be private?

Thanks for catching this!

https://codereview.chromium.org/1531983002/diff/40001/remoting/remoting_test....
File remoting/remoting_test.gypi (right):

https://codereview.chromium.org/1531983002/diff/40001/remoting/remoting_test....
remoting/remoting_test.gypi:315: 'protocol/connection_unittest.cc.cc',
On 2015/12/17 17:29:11, joedow wrote:
> duplicate file extension ".cc.cc".

Done.

[Sergey Ulanov, 2015-12-17 19:06:50]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-12-17 19:06:50]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/1531983002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-12-17 19:08:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531983002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531983002/60001

[Sergey Ulanov, 2015-12-17 20:02:56]

The CQ bit was unchecked by sergeyu@chromium.org

[Sergey Ulanov, 2015-12-17 21:20:35]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-12-17 21:20:35]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/1531983002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-12-17 21:21:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531983002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531983002/80001

[commit-bot: I haz the power, 2015-12-17 22:16:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 22:16:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-12-17 22:21:09]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-12-17 22:21:09]

The patchset sent to the CQ was uploaded after l-g-t-m from joedow@chromium.org
Link to the patchset: https://codereview.chromium.org/1531983002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-12-17 22:23:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531983002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531983002/100001

[commit-bot: I haz the power, 2015-12-18 00:29:24]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-12-18 00:30:21]

Description was changed from

==========
Replace ice_connection_to_client_unittest.cc with connection_unittest.cc

The new tests setup both ends of the connection, which also means
they test both ends. Previously there were no unittests for
ConnectionToHostImpl. It will also be possible to use the same tests
for WebRTC-based connections.
==========

to

==========
Replace ice_connection_to_client_unittest.cc with connection_unittest.cc

The new tests setup both ends of the connection, which also means
they test both ends. Previously there were no unittests for
ConnectionToHostImpl. It will also be possible to use the same tests
for WebRTC-based connections.

Committed: https://crrev.com/ba057a794e38c6c76fdc61a633d603a605caf9ce
Cr-Commit-Position: refs/heads/master@{#365948}
==========

[commit-bot: I haz the power, 2015-12-18 00:30:22]

Patchset 5 (id:??) landed as
https://crrev.com/ba057a794e38c6c76fdc61a633d603a605caf9ce
Cr-Commit-Position: refs/heads/master@{#365948}