Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1536663003: Force Account Consistency off for Logout call on iOS. (Closed)

Created:
5 years ago by bzanotti
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Force Account Consistency off for Logout call on iOS. The GaiaAuthFetcher Logout call needs Account Consistency to be disabled to work properly. On iOS, the state of Account Consistency is handled by cookies set on the various Google domains. Sadly, the cookie clearing request is not synchronized with the Logout call and there is a race between the two. This CL forces the cookie to be invalid during the Logout request to ensure the accounts will be cleared. The cookie will eventually be invalidated in the WKWebView cookie jar when AccountConsistencyService finishes. BUG=569501 Review URL: https://codereview.chromium.org/1522873002 Cr-Commit-Position: refs/heads/master@{#365248} (cherry picked from commit def2982edb1814b13ca9dd03b619521231f65bf2) Committed: https://chromium.googlesource.com/chromium/src/+/06c212a23b9dbbb80a75893d6cd4594c18f8e7e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M google_apis/gaia/gaia_auth_fetcher.h View 2 chunks +6 lines, -0 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bzanotti
5 years ago (2015-12-17 13:56:01 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06c212a23b9dbbb80a75893d6cd4594c18f8e7e4.

Powered by Google App Engine
This is Rietveld 408576698