Force Account Consistency off for Logout call on iOS.

Force Account Consistency off for Logout call on iOS.

The GaiaAuthFetcher Logout call needs Account Consistency to be
disabled to work properly. On iOS, the state of Account Consistency is
handled by cookies set on the various Google domains. Sadly, the cookie
clearing request is not synchronized with the Logout call and there is
a race between the two.

This CL forces the cookie to be invalid during the Logout request to
ensure the accounts will be cleared. The cookie will eventually be
invalidated in the WKWebView cookie jar when AccountConsistencyService
finishes.

BUG=569501
Committed: https://crrev.com/def2982edb1814b13ca9dd03b619521231f65bf2
Cr-Commit-Position: refs/heads/master@{#365248}

[bzanotti, 2015-12-14 12:34:19]

bzanotti@chromium.org changed reviewers:
+ msarda@chromium.org, rogerta@chromium.org

[bzanotti, 2015-12-14 12:34:20]

Please take a look.

[msarda, 2015-12-14 12:44:14]

lgtm

[Roger Tawa OOO till Jul 10th, 2015-12-14 22:27:22]

Looks good, but why is this specific to iOS?

[bzanotti, 2015-12-14 22:50:03]

On 2015/12/14 22:27:22, Roger Tawa wrote:
> Looks good, but why is this specific to iOS?

The X-CHROME-CONNECTED cookie is only used on iOS (WKBling to be precise). On
all other platforms, the X-Chrome-Connected header is used, which doesn't need
to be removed (it is just not added to request) and, as such, isn't affected by
this issue.

[Roger Tawa OOO till Jul 10th, 2015-12-15 13:30:22]

lgtm

[bzanotti, 2015-12-15 13:32:08]

The CQ bit was checked by bzanotti@chromium.org

[commit-bot: I haz the power, 2015-12-15 13:33:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1522873002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1522873002/1

[commit-bot: I haz the power, 2015-12-15 14:52:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-15 14:54:06]

Description was changed from

==========
Force Account Consistency off for Logout call on iOS.

The GaiaAuthFetcher Logout call needs Account Consistency to be
disabled to work properly. On iOS, the state of Account Consistency is
handled by cookies set on the various Google domains. Sadly, the cookie
clearing request is not synchronized with the Logout call and there is
a race between the two.

This CL forces the cookie to be invalid during the Logout request to
ensure the accounts will be cleared. The cookie will eventually be
invalidated in the WKWebView cookie jar when AccountConsistencyService
finishes.

BUG=569501
==========

to

==========
Force Account Consistency off for Logout call on iOS.

The GaiaAuthFetcher Logout call needs Account Consistency to be
disabled to work properly. On iOS, the state of Account Consistency is
handled by cookies set on the various Google domains. Sadly, the cookie
clearing request is not synchronized with the Logout call and there is
a race between the two.

This CL forces the cookie to be invalid during the Logout request to
ensure the accounts will be cleared. The cookie will eventually be
invalidated in the WKWebView cookie jar when AccountConsistencyService
finishes.

BUG=569501

Committed: https://crrev.com/def2982edb1814b13ca9dd03b619521231f65bf2
Cr-Commit-Position: refs/heads/master@{#365248}
==========

[commit-bot: I haz the power, 2015-12-15 14:54:07]

Patchset 1 (id:??) landed as
https://crrev.com/def2982edb1814b13ca9dd03b619521231f65bf2
Cr-Commit-Position: refs/heads/master@{#365248}