Chromium Code Reviews| Index: components/autofill/content/renderer/password_autofill_agent.cc |
| diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc |
| index ca9117b8c840eb7c62570773978a9dd122f602b2..303db579f976dd21bd7a38eb101c3007c812dee7 100644 |
| --- a/components/autofill/content/renderer/password_autofill_agent.cc |
| +++ b/components/autofill/content/renderer/password_autofill_agent.cc |
| @@ -1053,16 +1053,10 @@ void PasswordAutofillAgent::SendPasswordForms(bool only_visible) { |
| } |
| if (only_visible) { |
| - bool is_last_load = true; |
| - for (blink::WebFrame* frame = render_frame()->GetWebFrame()->top(); frame; |
| - frame = frame->traverseNext(false)) { |
| - if (frame != render_frame()->GetWebFrame() && frame->isLoading()) { |
| - is_last_load = false; |
| - break; |
| - } |
| - } |
| + blink::WebFrame* frame = render_frame()->GetWebFrame()->top(); |
|
vabr (Chromium)
2015/12/17 13:51:48
nit: frame -> main_frame
(to make clearer below, w
dvadym
2015/12/17 14:00:27
It's not necessary the main frame, it might be a t
dvadym
2015/12/17 14:17:40
Thanks, it's really top frame and it makes sense t
|
| + bool did_stop_loading = !frame || !frame->isLoading(); |
| Send(new AutofillHostMsg_PasswordFormsRendered(routing_id(), password_forms, |
| - is_last_load)); |
| + did_stop_loading)); |
| } else { |
| Send(new AutofillHostMsg_PasswordFormsParsed(routing_id(), password_forms)); |
| } |