Fix saving password in Password Manager on nytimes.com.

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/i18n/case_conversion.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 1035 matching lines @@
   }
 
   if (password_forms.empty() && !only_visible) {
     // We need to send the PasswordFormsRendered message regardless of whether
     // there are any forms visible, as this is also the code path that triggers
     // showing the infobar.
     return;
   }
 
   if (only_visible) {
-    bool is_last_load = true;
-    for (blink::WebFrame* frame = render_frame()->GetWebFrame()->top(); frame;
-         frame = frame->traverseNext(false)) {
-      if (frame != render_frame()->GetWebFrame() && frame->isLoading()) {
-        is_last_load = false;
-        break;
-      }
-    }
+    blink::WebFrame* frame = render_frame()->GetWebFrame()->top();

[vabr (Chromium), 2015/12/17 13:51:48]

nit: frame -> main_frame
(to make clearer below, which frame this is about)

[dvadym, 2015/12/17 14:00:27]

It's not necessary the main frame, it might be a target frame of this form for
example.

[dvadym, 2015/12/17 14:17:40]

Thanks, it's really top frame and it makes sense to check loading of the main
frame.

+    bool did_stop_loading = !frame || !frame->isLoading();
     Send(new AutofillHostMsg_PasswordFormsRendered(routing_id(), password_forms,
-                                                   is_last_load));
+                                                   did_stop_loading));
   } else {
     Send(new AutofillHostMsg_PasswordFormsParsed(routing_id(), password_forms));
   }
 }
 
 bool PasswordAutofillAgent::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PasswordAutofillAgent, message)
     IPC_MESSAGE_HANDLER(AutofillMsg_FillPasswordForm, OnFillPasswordForm)
     IPC_MESSAGE_HANDLER(AutofillMsg_SetLoggingState, OnSetLoggingState)
@@ skipping 427 matching lines @@
 }
 
 bool PasswordAutofillAgent::ProvisionallySavedPasswordIsValid() {
   return provisionally_saved_form_ &&
          !provisionally_saved_form_->username_value.empty() &&
          !(provisionally_saved_form_->password_value.empty() &&
          provisionally_saved_form_->new_password_value.empty());
 }
 
 }  // namespace autofill