Skip comments code blocks indented with 4 spaces.

Skip comments code blocks indented with 4 spaces.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5eb20232e3ebf536123d43e57d9133ec5bafac39

[Brian Wilkerson, 2015-12-16 21:23:33]

LGTM

https://codereview.chromium.org/1536483002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/1536483002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:3890: comment, index, 0x20, 0x20,
0x20, 0x20, 0x20)) {
That looks like five spaces to me. (If we only required four then some
additional code blocks would be excluded.)

[scheglov, 2015-12-16 21:27:06]

https://codereview.chromium.org/1536483002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/1536483002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:3890: comment, index, 0x20, 0x20,
0x20, 0x20, 0x20)) {
On 2015/12/16 21:23:33, Brian Wilkerson wrote:
> That looks like five spaces to me. (If we only required four then some
> additional code blocks would be excluded.)

According to
https://www.dartlang.org/effective-dart/documentation/#markdown

and

https://www.dartlang.org/effective-dart/documentation/#consider-including-cod...

It is 4 spaces, but the fifth is after /// and is not part of these four.

[Brian Wilkerson, 2015-12-16 21:35:02]

https://codereview.chromium.org/1536483002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/1536483002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:3890: comment, index, 0x20, 0x20,
0x20, 0x20, 0x20)) {
Given the example you showed me earlier, it's possible that not everyone read
those references. I don't care too much whether it changes or not, but we'd
catch more places that were intended to be code blocks if we only require 4
spaces.

[scheglov, 2015-12-16 22:28:18]

https://codereview.chromium.org/1536483002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/parser.dart (right):

https://codereview.chromium.org/1536483002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/parser.dart:3890: comment, index, 0x20, 0x20,
0x20, 0x20, 0x20)) {
On 2015/12/16 21:35:02, Brian Wilkerson wrote:
> Given the example you showed me earlier, it's possible that not everyone read
> those references. I don't care too much whether it changes or not, but we'd
> catch more places that were intended to be code blocks if we only require 4
> spaces.

Acknowledged.

[scheglov, 2015-12-16 22:28:33]

Description was changed from

==========
Skip comments code blocks indented with 4 spaces.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Skip comments code blocks indented with 4 spaces.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5eb20232e3ebf536123d43e57d9133ec5bafac39
==========

[scheglov, 2015-12-16 22:28:35]

Committed patchset #1 (id:1) manually as
5eb20232e3ebf536123d43e57d9133ec5bafac39 (presubmit successful).