Skip comments code blocks indented with 4 spaces.

pkg/analyzer/lib/src/generated/parser.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.generated.parser;
 
 import 'dart:collection';
 import "dart:math" as math;
 
 import 'package:analyzer/src/generated/ast.dart';
@@ skipping 3868 matching lines @@
             comment, index, 0x2A, 0x20, 0x20, 0x20, 0x20, 0x20)) {
           int end = index + 6;
           while (end < length &&
               comment.codeUnitAt(end) != 0xD &&
               comment.codeUnitAt(end) != 0xA) {
             end = end + 1;
           }
           ranges.add(<int>[index, end]);
           index = end;
         }
+      } else if (StringUtilities.startsWith5(
+          comment, index, 0x20, 0x20, 0x20, 0x20, 0x20)) {

[Brian Wilkerson, 2015/12/16 21:23:33]

That looks like five spaces to me. (If we only required four then some
additional code blocks would be excluded.)

[scheglov, 2015/12/16 21:27:06]

According to
https://www.dartlang.org/effective-dart/documentation/#markdown

and

https://www.dartlang.org/effective-dart/documentation/#consider-including-cod...

It is 4 spaces, but the fifth is after /// and is not part of these four.

[Brian Wilkerson, 2015/12/16 21:35:02]

Given the example you showed me earlier, it's possible that not everyone read
those references. I don't care too much whether it changes or not, but we'd
catch more places that were intended to be code blocks if we only require 4
spaces.

[scheglov, 2015/12/16 22:28:18]

Acknowledged.

+        int end = index + 5;
+        while (end < length &&
+            comment.codeUnitAt(end) != 0xD &&
+            comment.codeUnitAt(end) != 0xA) {
+          end = end + 1;
+        }
+        ranges.add(<int>[index, end]);
+        index = end;
       } else if (index + 1 < length &&
           currentChar == 0x5B &&
           comment.codeUnitAt(index + 1) == 0x3A) {
         int end = StringUtilities.indexOf2(comment, index + 2, 0x3A, 0x5D);
         if (end < 0) {
           end = length;
         }
         ranges.add(<int>[index, end]);
         index = end + 1;
       } else {
@@ skipping 1137 matching lines @@
    *         '[' 'new'? qualified ']' libraryReference?
    *
    *     libraryReference ::=
    *          '(' stringLiteral ')'
    */
   List<CommentReference> _parseCommentReferences(
       List<DocumentationCommentToken> tokens) {
     List<CommentReference> references = new List<CommentReference>();
     for (DocumentationCommentToken token in tokens) {
       String comment = token.lexeme;
-      comment = _removeGitHubCodeBlocks(comment);
+      comment = _removeCodeBlocksGitHub(comment);
       int length = comment.length;
       List<List<int>> codeBlockRanges = _getCodeBlockRanges(comment);
       int leftIndex = comment.indexOf('[');
       while (leftIndex >= 0 && leftIndex + 1 < length) {
         List<int> range = _findRange(codeBlockRanges, leftIndex);
         if (range == null) {
           int nameOffset = token.offset + leftIndex + 1;
           int rightIndex = JavaString.indexOf(comment, ']', leftIndex);
           if (rightIndex >= 0) {
             int firstChar = comment.codeUnitAt(leftIndex + 1);
@@ skipping 3169 matching lines @@
    * is the current token, `1` is the next token, etc.
    */
   Token _peekAt(int distance) {
     Token token = _currentToken;
     for (int i = 0; i < distance; i++) {
       token = token.next;
     }
     return token;
   }
 
-  String _removeGitHubCodeBlocks(String comment) {
+  String _removeCodeBlocksGitHub(String comment) {
     int index = 0;
     while (true) {
       int beginIndex = comment.indexOf('`', index);
       if (beginIndex == -1) {
         break;
       }
       int endIndex = comment.indexOf('`', beginIndex + 1);
       if (endIndex == -1) {
         break;
       }
@@ skipping 3062 matching lines @@
   }
 
   /**
    * Copy resolution data from the [fromNode] to the [toNode].
    */
   static void copyResolutionData(AstNode fromNode, AstNode toNode) {
     ResolutionCopier copier = new ResolutionCopier();
     copier._isEqualNodes(fromNode, toNode);
   }
 }