Disable sysroot for x86 and x64 only

Disable sysroot for x86 and x64 only

In addition to https://codereview.chromium.org/1526163002
disable sysroot only for x86 and x64.

Keep using sysroot for other archs
due to crosscompiling.

BUG=none
R=fbarchard@chromium.org

Committed: https://chromium.googlesource.com/libyuv/libyuv/+/0f5c7660d1e98c5e6095bfcd7f73749150ca4362

[gordanac, 2015-12-21 15:03:30]

gordana.cmiljanovic@imgtec.com changed reviewers:
+ fbarchard@google.com

[gordanac, 2015-12-21 15:03:30]

Please take a look.

Change:
https://chromium.googlesource.com/libyuv/libyuv/+/be984a8b9a130671c098920600f...

broke mips linux build as per [1].

This is fixing it (I verified the change for mips only).

[1]
http://www.rt-rk.com/mips-buildbot/builders/build_and_test_chromium_trunk_for...

[kjellander_chromium, 2015-12-21 18:59:48]

kjellander@chromium.org changed reviewers:
+ kjellander@chromium.org

[kjellander_chromium, 2015-12-21 18:59:48]

https://codereview.chromium.org/1536403002/diff/1/libyuv.gyp
File libyuv.gyp (right):

https://codereview.chromium.org/1536403002/diff/1/libyuv.gyp#newcode25
libyuv.gyp:25: ['target_arch=="ia32" or target_arch=="x64"', {
I'm not sure about ARM here, so please run the trybots to ensure Android still
builds.

[fbarchard, 2015-12-21 19:02:25]

fbarchard@chromium.org changed reviewers:
+ fbarchard@chromium.org
- kjellander@chromium.org

[fbarchard, 2015-12-21 19:02:25]

background - I did this change as I rolled chromium deps forward, which was
because I had system errors on Windows.  The roll caused linux build errors to
do with gtest including standard headers, so I pulled in this change from
webrtc.  Its unclear if it was really necessary or affecting libyuv.

Note that if you bump the version, you should also update
include/libyuv/version.h to be in sync.  Its not necessary to bump versions..
mainly if there is an API change, the header version would allow ifdef's, and a
way to quote what version of libyuv you are on, when rolling into other projects
and/or version control systems.

[fbarchard, 2015-12-21 19:40:40]

lgtm
I ran git cl patch and git try, and try bots passed.

[fbarchard1, 2015-12-21 19:41:18]

Description was changed from

==========
Disable sysroot for x86 and x64 only

In addition to https://codereview.chromium.org/1526163002
disable sysroot only for x86 and x64.

Keep using sysroot for other archs
due to crosscompiling.

BUG=none
==========

to

==========
Disable sysroot for x86 and x64 only

In addition to https://codereview.chromium.org/1526163002
disable sysroot only for x86 and x64.

Keep using sysroot for other archs
due to crosscompiling.

BUG=none
R=fbarchard@chromium.org

Committed:
https://chromium.googlesource.com/libyuv/libyuv/+/0f5c7660d1e98c5e6095bfcd7f7...
==========

[fbarchard1, 2015-12-21 19:41:19]

Committed patchset #1 (id:1) manually as
0f5c7660d1e98c5e6095bfcd7f73749150ca4362 (presubmit successful).

[gordanac, 2015-12-22 15:54:06]

On 2015/12/21 19:02:25, fbarchard wrote:
> background - I did this change as I rolled chromium deps forward, which was
> because I had system errors on Windows.  The roll caused linux build errors to
> do with gtest including standard headers, so I pulled in this change from
> webrtc.  Its unclear if it was really necessary or affecting libyuv.
> 
> Note that if you bump the version, you should also update
> include/libyuv/version.h to be in sync.  Its not necessary to bump versions..
> mainly if there is an API change, the header version would allow ifdef's, and
a
> way to quote what version of libyuv you are on, when rolling into other
projects
> and/or version control systems.

Thank you for clarification. I actually thought version has to be increased in
each change.

Can we do the roll in Chromium?

[Sam Clegg, 2016-01-06 19:01:09]

On 2015/12/22 15:54:06, gordanac wrote:
> On 2015/12/21 19:02:25, fbarchard wrote:
> > background - I did this change as I rolled chromium deps forward, which was
> > because I had system errors on Windows.  The roll caused linux build errors
to
> > do with gtest including standard headers, so I pulled in this change from
> > webrtc.  Its unclear if it was really necessary or affecting libyuv.
> > 
> > Note that if you bump the version, you should also update
> > include/libyuv/version.h to be in sync.  Its not necessary to bump
versions..
> > mainly if there is an API change, the header version would allow ifdef's,
and
> a
> > way to quote what version of libyuv you are on, when rolling into other
> projects
> > and/or version control systems.
> 
> Thank you for clarification. I actually thought version has to be increased in
> each change.
> 
> Can we do the roll in Chromium?

Yes, can we roll this into chromium ASAP, since it should also fix the Linux ARM
builder.

In the long run we shouldn't be setting this value even for x86 as it will mean
that the sysroot is not used for the libyuv build but its used for the rest of
chrome, which is certainly wrong.

I suggest that we with make sure that the runhooks for libyuv correctly install
the sysroots, or set "use_sysroot=0" in gyp_libyuv where it won't effect the
chromium build.

[Sam Clegg, 2016-01-07 20:02:16]

On 2016/01/06 19:01:09, Sam Clegg wrote:
> On 2015/12/22 15:54:06, gordanac wrote:
> > On 2015/12/21 19:02:25, fbarchard wrote:
> > > background - I did this change as I rolled chromium deps forward, which
was
> > > because I had system errors on Windows.  The roll caused linux build
errors
> to
> > > do with gtest including standard headers, so I pulled in this change from
> > > webrtc.  Its unclear if it was really necessary or affecting libyuv.
> > > 
> > > Note that if you bump the version, you should also update
> > > include/libyuv/version.h to be in sync.  Its not necessary to bump
> versions..
> > > mainly if there is an API change, the header version would allow ifdef's,
> and
> > a
> > > way to quote what version of libyuv you are on, when rolling into other
> > projects
> > > and/or version control systems.
> > 
> > Thank you for clarification. I actually thought version has to be increased
in
> > each change.
> > 
> > Can we do the roll in Chromium?
> 
> Yes, can we roll this into chromium ASAP, since it should also fix the Linux
ARM
> builder.
> 
> In the long run we shouldn't be setting this value even for x86 as it will
mean
> that the sysroot is not used for the libyuv build but its used for the rest of
> chrome, which is certainly wrong.
> 
> I suggest that we with make sure that the runhooks for libyuv correctly
install
> the sysroots, or set "use_sysroot=0" in gyp_libyuv where it won't effect the
> chromium build.

Ping.  Can we get this rolled into chromium?