Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1526163002: bump chromium version and disable use_sysroot (Closed)

Created:
5 years ago by fbarchard1
Modified:
4 years, 11 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M libyuv.gyp View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (4 generated)
fbarchard1
5 years ago (2015-12-15 19:43:27 UTC) #1
fbarchard1
Committed patchset #1 (id:1) manually as be984a8b9a130671c098920600ffb44cbb559340 (presubmit successful).
5 years ago (2015-12-15 20:05:37 UTC) #4
Sam Clegg
https://codereview.chromium.org/1526163002/diff/1/libyuv.gyp File libyuv.gyp (right): https://codereview.chromium.org/1526163002/diff/1/libyuv.gyp#newcode24 libyuv.gyp:24: 'use_sysroot': 0, I think this broke the Linux ARM ...
4 years, 11 months ago (2016-01-06 18:37:34 UTC) #6
Sam Clegg
On 2016/01/06 18:37:34, Sam Clegg wrote: > https://codereview.chromium.org/1526163002/diff/1/libyuv.gyp > File libyuv.gyp (right): > > https://codereview.chromium.org/1526163002/diff/1/libyuv.gyp#newcode24 ...
4 years, 11 months ago (2016-01-06 18:41:07 UTC) #7
kjellander_chromium
4 years, 11 months ago (2016-01-11 20:36:03 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1526163002/diff/1/libyuv.gyp
File libyuv.gyp (right):

https://codereview.chromium.org/1526163002/diff/1/libyuv.gyp#newcode24
libyuv.gyp:24: 'use_sysroot': 0,
On 2016/01/06 18:37:34, Sam Clegg wrote:
> I think this broke the Linux ARM builder, where sysroot is required to be
used:
> https://build.chromium.org/p/chromium.fyi/builders/Linux%20ARM
> 
> Can you tell my why this change was needed?   Is udev actually used by libyuv?
 

Frank was making this change with the assumption that it was needed because
WebRTC was hitting problems with libudev being missing when using sysroots. It's
not used by libyuv so libyuv should be able to use sysroots.

For libyuv, this setting could go into a supplement.gypi file instead, as we do
in WebRTC. Then it won't affect downstream. Just make sure to put it into a
subdirectory, like 'source' or 'util' in this case.
That said, I think it's better to enable the sysroot again. But for the runhooks
step to execute you must then either roll chromium_revision (it only runs as
part of when
https://chromium.googlesource.com/libyuv/libyuv/+/master/sync_chromium.py runs),
or increment the SCRIPT_VERSION number in that file.

Powered by Google App Engine
This is Rietveld 408576698