Issue 15363004: Rename ShadowDescendant to ShadowPseudo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15363004: Rename ShadowDescendant to ShadowPseudo. (Closed)

Created:
7 years, 7 months ago by hayato

Modified:
7 years, 7 months ago

Reviewers:
Hajime Morrita, dglazkov

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears, tasak (please_use_google.com)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Rename ShadowDescendant to ShadowPseudo. ShadowDescendant is confusing name since that is likely to imply the same meaning used by ShadowDistributed. BUG=None R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150853

Patch Set 1 #

Patch Set 2 : sync with ToT #

Patch Set 3 : sync again #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
M	Source/core/css/CSSParser.cpp	View	1 2	2 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/css/CSSParserValues.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/CSSSelector.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/CSSSelector.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/SelectorChecker.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/SelectorFilter.cpp	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dglazkov

LGTM. One day, we'll straighten this whole plumbing to just use CSS Selectors spec terminology. ...

7 years, 7 months ago (2013-05-21 17:11:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hayato@chromium.org/15363004/1

7 years, 7 months ago (2013-05-22 01:48:32 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=6631

7 years, 7 months ago (2013-05-22 03:05:18 UTC) #4

hayato

7 years, 7 months ago (2013-05-22 03:25:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r150853 (presubmit successful).

Expand Messages | Collapse Messages