Issue 153623006: formatter nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153623006: formatter nits (Closed)

Created:
6 years, 10 months ago by kevmoo

Modified:
6 years, 8 months ago

Reviewers:
pquitslund

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

formatter nits

Patch Set 1 #

Total comments: 2

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
	M	pkg/analyzer/test/services/data/cu_tests.data	View		1 chunk	+22 lines, -1 line	2 comments	Download
	M	pkg/analyzer/test/services/data/stmt_tests.data	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

pquitslund

6 years, 10 months ago (2014-02-07 00:19:13 UTC) #1

Keep 'em comin'!

https://codereview.chromium.org/153623006/diff/1/pkg/analyzer/test/services/d...
File pkg/analyzer/test/services/data/cu_tests.data (right):

https://codereview.chromium.org/153623006/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/cu_tests.data:204: >>> one line call to super is
okay
Fixed!

https://codereview.chromium.org/153623006/diff/1/pkg/analyzer/test/services/d...
pkg/analyzer/test/services/data/cu_tests.data:212: >>> keep empty methods on a
single line
Fixed!

Expand Messages | Collapse Messages