Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1536083002: completion performance measurement for local status page (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

completion performance measurement for local status page R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e5bbeddf4d02e087327887c4269663c6d24e9991

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/domain_completion.dart View 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_core.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_performance.dart View 1 chunk +5 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 11 chunks +47 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-18 18:58:14 UTC) #2
scheglov
LGTM
5 years ago (2015-12-18 19:52:48 UTC) #3
danrubel
5 years ago (2015-12-19 16:12:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e5bbeddf4d02e087327887c4269663c6d24e9991 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698