pkg/analysis_server/lib/src/services/completion/completion_core.dart - Issue 1536083002: completion performance measurement for local status page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_core.dart

Issue 1536083002: completion performance measurement for local status page (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/domain_completion.dart ('k') | pkg/analysis_server/lib/src/services/completion/completion_performance.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/completion_core.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/completion_core.dart b/pkg/analysis_server/lib/src/services/completion/completion_core.dart

index 3dce012eb5e002bcb906f2d1ee85e49977c729b2..e0635aa9e062fe422306bd295515bf18224a085a 100644

--- a/pkg/analysis_server/lib/src/services/completion/completion_core.dart

+++ b/pkg/analysis_server/lib/src/services/completion/completion_core.dart

@@ -5,6 +5,7 @@

library analysis_server.src.services.completion.completion_core;

import 'package:analysis_server/src/provisional/completion/completion_core.dart';

+import 'package:analysis_server/src/services/completion/completion_performance.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

import 'package:analyzer/file_system/file_system.dart';

import 'package:analyzer/src/generated/engine.dart';

@@ -47,11 +48,13 @@ class CompletionRequestImpl implements CompletionRequest {

@override

final SearchEngine searchEngine;

+ final CompletionPerformance performance;

/**

* Initialize a newly created completion request based on the given arguments.

CompletionRequestImpl(this.context, this.resourceProvider, this.searchEngine,

- this.source, this.offset) {

+ this.source, this.offset, this.performance) {

replacementOffset = offset;

replacementLength = 0;

}