Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 1535983003: Re-attempt rebaseline of one test to debug rebaseline script. (Closed)

Created:
5 years ago by wkorman
Modified:
5 years ago
Reviewers:
Noel Gordon
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-attempt rebaseline of one test to debug rebaseline script. TBR=noel BUG=569919, 570401 Committed: https://chromium.googlesource.com/chromium/src/+/f8246c1a4a26e396fe1fb2305b95169343cbfe96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
wkorman
5 years ago (2015-12-18 23:12:12 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8246c1a4a26e396fe1fb2305b95169343cbfe96 Cr-Commit-Position: refs/heads/master@{#366197}
5 years ago (2015-12-18 23:15:18 UTC) #7
wkorman
Committed patchset #1 (id:1) manually as f8246c1a4a26e396fe1fb2305b95169343cbfe96 (presubmit successful).
5 years ago (2015-12-18 23:15:46 UTC) #9
Noel Gordon
LGTM
5 years ago (2015-12-18 23:44:35 UTC) #10
Noel Gordon
Still seeing all white images in the newly added image results that came as a ...
5 years ago (2015-12-20 23:31:28 UTC) #11
Noel Gordon
5 years ago (2015-12-20 23:32:00 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1540193002/ by noel@chromium.org.

The reason for reverting is: Thanks for trying Walter, but we are still seeing
issues per issue 570401 worst luck.  Backing this out for now..

Powered by Google App Engine
This is Rietveld 408576698