Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp

Issue 1535943005: Initial implementation of bindings and basic classes for worklets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address (most) comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
diff --git a/third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp b/third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
index d13e81f39184e9850989051d1b9743fe9b6dcf5e..7af5bc0baab0482d1f37b9d9b93579bc8db6b40d 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
+++ b/third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp
@@ -4,9 +4,10 @@
#include "bindings/modules/v8/ModuleBindingsInitializer.h"
+#include "bindings/core/v8/ModuleProxy.h"
#include "bindings/core/v8/V8PerIsolateData.h"
#include "bindings/modules/v8/SerializedScriptValueForModulesFactory.h"
-#include "core/dom/ExecutionContext.h"
+#include "bindings/modules/v8/V8BindingForModules.h"
namespace blink {
@@ -16,6 +17,8 @@ void initPartialInterfacesInModules();
void ModuleBindingsInitializer::init()
{
+ ModuleProxy::moduleProxy().registerToExecutionContextForModules(toExecutionContextForModules);
+ ModuleProxy::moduleProxy().registerToV8ContextForModules(toV8ContextForModules);
haraken 2016/01/08 04:59:07 Sorry for not being clear. My suggestion is: - De
ikilpatrick 2016/01/11 04:13:19 Done. Has a global in a anon namespace.
initPartialInterfacesInModules();
SerializedScriptValueFactory::initialize(new SerializedScriptValueForModulesFactory);
}

Powered by Google App Engine
This is Rietveld 408576698