third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp - Issue 1535943005: Initial implementation of bindings and basic classes for worklets.

Side by Side Diff: third_party/WebKit/Source/bindings/modules/v8/ModuleBindingsInitializer.cpp

Issue 1535943005: Initial implementation of bindings and basic classes for worklets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address (most) comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/v8.gypi ('k') | third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h » ('j') | third_party/WebKit/Source/modules/worklet/WorkletGlobalScope.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "bindings/modules/v8/ModuleBindingsInitializer.h"	5 #include "bindings/modules/v8/ModuleBindingsInitializer.h"

6	6

	7 #include "bindings/core/v8/ModuleProxy.h"

7 #include "bindings/core/v8/V8PerIsolateData.h"	8 #include "bindings/core/v8/V8PerIsolateData.h"

8 #include "bindings/modules/v8/SerializedScriptValueForModulesFactory.h"	9 #include "bindings/modules/v8/SerializedScriptValueForModulesFactory.h"

9 #include "core/dom/ExecutionContext.h"	10 #include "bindings/modules/v8/V8BindingForModules.h"

10	11

11 namespace blink {	12 namespace blink {

12	13

13 // initPartialInterfacesInModules is generated by	14 // initPartialInterfacesInModules is generated by

14 // generate_init_partial_interfaces.py.	15 // generate_init_partial_interfaces.py.

15 void initPartialInterfacesInModules();	16 void initPartialInterfacesInModules();

16	17

17 void ModuleBindingsInitializer::init()	18 void ModuleBindingsInitializer::init()

18 {	19 {

	20 ModuleProxy::moduleProxy().registerToExecutionContextForModules(toExecutionC ontextForModules);

	21 ModuleProxy::moduleProxy().registerToV8ContextForModules(toV8ContextForModul es);
	haraken 2016/01/08 04:59:07 Sorry for not being clear. My suggestion is: - De Sorry for not being clear. My suggestion is: - Define toExecutionContextForModules and toV8ContextForModules in core/v8/V8Binding. - Define the actual contents of toExecutionContextForModules and toV8ContextForModules in modules/v8/V8BindingForModules. - Call V8BindingForModules::initialize(toExecutionContextForModules, toV8ContextForModules) from ModuleBindingsInitializer::init() and register the methods. - Don't introduce ModuleProxy. ikilpatrick 2016/01/11 04:13:19 Done. Has a global in a anon namespace. Show quoted text On 2016/01/08 04:59:07, haraken wrote: > > Sorry for not being clear. My suggestion is: > > - Define toExecutionContextForModules and toV8ContextForModules in > core/v8/V8Binding. > > - Define the actual contents of toExecutionContextForModules and > toV8ContextForModules in modules/v8/V8BindingForModules. > > - Call V8BindingForModules::initialize(toExecutionContextForModules, > toV8ContextForModules) from ModuleBindingsInitializer::init() and register the > methods. > > - Don't introduce ModuleProxy. > Done. Has a global in a anon namespace.
19 initPartialInterfacesInModules();	22 initPartialInterfacesInModules();

20 SerializedScriptValueFactory::initialize(new SerializedScriptValueForModules Factory);	23 SerializedScriptValueFactory::initialize(new SerializedScriptValueForModules Factory);

21 }	24 }

22	25

23 } // namespace blink	26 } // namespace blink

OLD	NEW