Issue 1535783002: Reader Mode cannot be permanently disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1535783002: Reader Mode cannot be permanently disabled (Closed)

Created:
5 years ago by mdjones

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Reader Mode cannot be permanently disabled This change removes the logic from the close button that disables the Reader Mode panel for a particular tab. Now refreshing the page will reshow the panel. BUG=570407 Review URL: https://codereview.chromium.org/1514603004 Cr-Commit-Position: refs/heads/master@{#364459} (cherry picked from commit b1da094048e4c57e0579c39a91eb0e3b174824e8) Committed: https://chromium.googlesource.com/chromium/src/+/e35245562748342d7faa27d6291a0a03fcfe7e53

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java	View		1 chunk	+3 lines, -9 lines	0 comments	Download

Total messages: 2 (1 generated)

mdjones

5 years ago (2015-12-17 19:12:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e35245562748342d7faa27d6291a0a03fcfe7e53.