Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1514603004: Reader Mode cannot be permanently disabled (Closed)

Created:
5 years ago by mdjones
Modified:
5 years ago
Reviewers:
wychen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reader Mode cannot be permanently disabled This change removes the logic from the close button that disables the Reader Mode panel for a particular tab. Now refreshing the page will reshow the panel. BUG=570407 Committed: https://crrev.com/b1da094048e4c57e0579c39a91eb0e3b174824e8 Cr-Commit-Position: refs/heads/master@{#364459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mdjones
PTAL
5 years ago (2015-12-10 18:13:52 UTC) #2
wychen
lgtm
5 years ago (2015-12-10 19:06:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514603004/1
5 years ago (2015-12-10 19:17:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:28:01 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-10 20:29:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1da094048e4c57e0579c39a91eb0e3b174824e8
Cr-Commit-Position: refs/heads/master@{#364459}

Powered by Google App Engine
This is Rietveld 408576698