Oilpan: eagerly finalize StyleFetchedImage* image resource clients.

Oilpan: eagerly finalize StyleFetchedImage* image resource clients.

Extend our practice of eagerly finalizing ImageResourceClients to
StyleFetchedImage and StyleFetchedImageSet.

R=haraken
BUG=

Committed: https://crrev.com/e23cd28762470c6bd6bf3b8ed8a5c23d1c2ada92
Cr-Commit-Position: refs/heads/master@{#366092}

[sof, 2015-12-18 12:05:17]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 12:05:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535643005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535643005/1

[sof, 2015-12-18 12:19:09]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 12:19:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535643005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535643005/20001

[sof, 2015-12-18 12:24:14]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-12-18 12:24:15]

please take a look.

Trying to address flaky crasher,
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...

(ResourcePtr<> and the Resource hierarchy needs better Oilpan treatment overall,
but not here.)

[sof, 2015-12-18 13:33:14]

The CQ bit was unchecked by sigbjornf@opera.com

[haraken, 2015-12-18 13:52:47]

On 2015/12/18 12:24:15, sof wrote:
> please take a look.
> 
> Trying to address flaky crasher,
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...
> 
> (ResourcePtr<> and the Resource hierarchy needs better Oilpan treatment
overall,
> but not here.)

Agreed. I'd prefer using a pre-finalizer than eager finalization, but it's more
important to consider a better treatment on the Resource hierarchy.

LGTM.

[sof, 2015-12-18 14:03:38]

Description was changed from

==========
Oilpan: eagerly finalize StyleFetchedImage* image resource clients.

Extend our practice of eagerly finalizing ImageResourceClients to
StyleFetchedImage and StyleFetchedImageSet.

R=
BUG=
==========

to

==========
Oilpan: eagerly finalize StyleFetchedImage* image resource clients.

Extend our practice of eagerly finalizing ImageResourceClients to
StyleFetchedImage and StyleFetchedImageSet.

R=haraken
BUG=
==========

[sof, 2015-12-18 14:03:49]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-12-18 14:03:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1535643005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1535643005/20001

[commit-bot: I haz the power, 2015-12-18 15:08:18]

Description was changed from

==========
Oilpan: eagerly finalize StyleFetchedImage* image resource clients.

Extend our practice of eagerly finalizing ImageResourceClients to
StyleFetchedImage and StyleFetchedImageSet.

R=haraken
BUG=
==========

to

==========
Oilpan: eagerly finalize StyleFetchedImage* image resource clients.

Extend our practice of eagerly finalizing ImageResourceClients to
StyleFetchedImage and StyleFetchedImageSet.

R=haraken
BUG=
==========

[commit-bot: I haz the power, 2015-12-18 15:08:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-18 15:09:43]

Description was changed from

==========
Oilpan: eagerly finalize StyleFetchedImage* image resource clients.

Extend our practice of eagerly finalizing ImageResourceClients to
StyleFetchedImage and StyleFetchedImageSet.

R=haraken
BUG=
==========

to

==========
Oilpan: eagerly finalize StyleFetchedImage* image resource clients.

Extend our practice of eagerly finalizing ImageResourceClients to
StyleFetchedImage and StyleFetchedImageSet.

R=haraken
BUG=

Committed: https://crrev.com/e23cd28762470c6bd6bf3b8ed8a5c23d1c2ada92
Cr-Commit-Position: refs/heads/master@{#366092}
==========

[commit-bot: I haz the power, 2015-12-18 15:09:44]

Patchset 2 (id:??) landed as
https://crrev.com/e23cd28762470c6bd6bf3b8ed8a5c23d1c2ada92
Cr-Commit-Position: refs/heads/master@{#366092}

[sof, 2015-12-18 22:02:37]

On 2015/12/18 13:52:47, haraken wrote:
> On 2015/12/18 12:24:15, sof wrote:
> > please take a look.
> > 
> > Trying to address flaky crasher,
> >
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...
> > 
> > (ResourcePtr<> and the Resource hierarchy needs better Oilpan treatment
> overall,
> > but not here.)
> 
> Agreed. I'd prefer using a pre-finalizer than eager finalization, but it's
more
> important to consider a better treatment on the Resource hierarchy.
> 
> LGTM.

Hmm, unforeseen overlap here with the eager finalization of ScrollableAreas
(which a FrameView is),


https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...

so prefinalizers are unavoidable; in the short term.
https://codereview.chromium.org/1536113003/ does this.