Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1535643005: Oilpan: eagerly finalize StyleFetchedImage* image resource clients. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: eagerly finalize StyleFetchedImage* image resource clients. Extend our practice of eagerly finalizing ImageResourceClients to StyleFetchedImage and StyleFetchedImageSet. R=haraken BUG= Committed: https://crrev.com/e23cd28762470c6bd6bf3b8ed8a5c23d1c2ada92 Cr-Commit-Position: refs/heads/master@{#366092}

Patch Set 1 #

Patch Set 2 : adjust #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535643005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535643005/1
5 years ago (2015-12-18 12:05:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535643005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535643005/20001
5 years ago (2015-12-18 12:19:25 UTC) #4
sof
please take a look. Trying to address flaky crasher, https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/5512/layout-test-results/inspector/sources/debugger-ui/watch-expressions-panel-switch-crash-log.txt (ResourcePtr<> and the Resource hierarchy ...
5 years ago (2015-12-18 12:24:15 UTC) #6
haraken
On 2015/12/18 12:24:15, sof wrote: > please take a look. > > Trying to address ...
5 years ago (2015-12-18 13:52:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1535643005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1535643005/20001
5 years ago (2015-12-18 14:03:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 15:08:21 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e23cd28762470c6bd6bf3b8ed8a5c23d1c2ada92 Cr-Commit-Position: refs/heads/master@{#366092}
5 years ago (2015-12-18 15:09:44 UTC) #15
sof
5 years ago (2015-12-18 22:02:37 UTC) #16
Message was sent while issue was closed.
On 2015/12/18 13:52:47, haraken wrote:
> On 2015/12/18 12:24:15, sof wrote:
> > please take a look.
> > 
> > Trying to address flaky crasher,
> >
>
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...
> > 
> > (ResourcePtr<> and the Resource hierarchy needs better Oilpan treatment
> overall,
> > but not here.)
> 
> Agreed. I'd prefer using a pre-finalizer than eager finalization, but it's
more
> important to consider a better treatment on the Resource hierarchy.
> 
> LGTM.

Hmm, unforeseen overlap here with the eager finalization of ScrollableAreas
(which a FrameView is),


https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oil...

so prefinalizers are unavoidable; in the short term.
https://codereview.chromium.org/1536113003/ does this.

Powered by Google App Engine
This is Rietveld 408576698