Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: third_party/WebKit/Source/core/style/StyleFetchedImageSet.h

Issue 1535643005: Oilpan: eagerly finalize StyleFetchedImage* image resource clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adjust Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImage.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 bool imageHasRelativeHeight() const override; 67 bool imageHasRelativeHeight() const override;
68 void computeIntrinsicDimensions(const LayoutObject*, Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) override; 68 void computeIntrinsicDimensions(const LayoutObject*, Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio) override;
69 bool usesImageContainerSize() const override; 69 bool usesImageContainerSize() const override;
70 void addClient(LayoutObject*) override; 70 void addClient(LayoutObject*) override;
71 void removeClient(LayoutObject*) override; 71 void removeClient(LayoutObject*) override;
72 PassRefPtr<Image> image(const LayoutObject*, const IntSize&, float) const ov erride; 72 PassRefPtr<Image> image(const LayoutObject*, const IntSize&, float) const ov erride;
73 float imageScaleFactor() const override { return m_imageScaleFactor; } 73 float imageScaleFactor() const override { return m_imageScaleFactor; }
74 bool knownToBeOpaque(const LayoutObject*) const override; 74 bool knownToBeOpaque(const LayoutObject*) const override;
75 ImageResource* cachedImage() const override; 75 ImageResource* cachedImage() const override;
76 76
77 #if ENABLE(OILPAN)
78 // Promptly remove as a ImageResource client.
79 EAGERLY_FINALIZE();
80 DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();
81 #endif
77 DECLARE_VIRTUAL_TRACE(); 82 DECLARE_VIRTUAL_TRACE();
78 83
79 private: 84 private:
80 StyleFetchedImageSet(ImageResource*, float imageScaleFactor, CSSImageSetValu e*, const KURL&); 85 StyleFetchedImageSet(ImageResource*, float imageScaleFactor, CSSImageSetValu e*, const KURL&);
81 86
82 String debugName() const override { return "StyleFetchedImageSet"; } 87 String debugName() const override { return "StyleFetchedImageSet"; }
83 88
84 ResourcePtr<ImageResource> m_bestFitImage; 89 ResourcePtr<ImageResource> m_bestFitImage;
85 float m_imageScaleFactor; 90 float m_imageScaleFactor;
86 91
87 RawPtrWillBeMember<CSSImageSetValue> m_imageSetValue; // Not retained; it ow ns us. 92 RawPtrWillBeMember<CSSImageSetValue> m_imageSetValue; // Not retained; it ow ns us.
88 const KURL m_url; 93 const KURL m_url;
89 }; 94 };
90 95
91 DEFINE_STYLE_IMAGE_TYPE_CASTS(StyleFetchedImageSet, isImageResourceSet()); 96 DEFINE_STYLE_IMAGE_TYPE_CASTS(StyleFetchedImageSet, isImageResourceSet());
92 97
93 } // namespace blink 98 } // namespace blink
94 99
95 #endif // StyleFetchedImageSet_h 100 #endif // StyleFetchedImageSet_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/StyleFetchedImage.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698