Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1535533002: Resolve comment references before function type aliases. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resolve comment references before function type aliases. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9cb4fc5f1d40cc6dea26f2a3cc919974f0ef00a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +15 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-16 22:17:41 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-16 22:31:27 UTC) #2
scheglov
5 years ago (2015-12-16 23:13:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9cb4fc5f1d40cc6dea26f2a3cc919974f0ef00a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698