Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: pkg/analyzer/test/generated/non_error_resolver_test.dart

Issue 1535533002: Resolve comment references before function type aliases. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/non_error_resolver_test.dart
diff --git a/pkg/analyzer/test/generated/non_error_resolver_test.dart b/pkg/analyzer/test/generated/non_error_resolver_test.dart
index 876354caf7f11c970f4e8c068b60f7af6e757454..17e9c8a194c1f20b637b09c6b847716681fead2a 100644
--- a/pkg/analyzer/test/generated/non_error_resolver_test.dart
+++ b/pkg/analyzer/test/generated/non_error_resolver_test.dart
@@ -1001,6 +1001,40 @@ foo(int p) => null;''';
(obj) => obj is ParameterElement, ParameterElement, ref.staticElement);
}
+ void test_commentReference_beforeFunctionTypeAlias() {
+ String code = r'''
+/// [p]
+typedef Foo(int p);
+''';
+ Source source = addSource(code);
+ computeLibrarySourceErrors(source);
+ assertNoErrors(source);
+ verify([source]);
+ CompilationUnit unit = _getResolvedLibraryUnit(source);
+ SimpleIdentifier ref = EngineTestCase.findNode(
+ unit, code, "p]", (node) => node is SimpleIdentifier);
+ EngineTestCase.assertInstanceOf(
+ (obj) => obj is ParameterElement, ParameterElement, ref.staticElement);
+ }
+
+ void test_commentReference_beforeGetter() {
+ String code = r'''
+abstract class A {
+ /// [int]
+ get g => null;
+}''';
+ Source source = addSource(code);
+ computeLibrarySourceErrors(source);
+ assertNoErrors(source);
+ verify([source]);
+ CompilationUnit unit = _getResolvedLibraryUnit(source);
+ {
+ SimpleIdentifier ref = EngineTestCase.findNode(
+ unit, code, "int]", (node) => node is SimpleIdentifier);
+ expect(ref.staticElement, isNotNull);
+ }
+ }
+
void test_commentReference_beforeMethod() {
String code = r'''
abstract class A {
« no previous file with comments | « pkg/analyzer/lib/src/generated/resolver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698