Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153553008: Wire InstallFinished and add some InstallEvent.waitUntil tests (Closed)

Created:
6 years, 10 months ago by kinuko
Modified:
6 years, 10 months ago
Reviewers:
alecflett
CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, jsbell
Visibility:
Public.

Description

Wire InstallFinished and add some InstallEvent.waitUntil tests BUG=285976 TEST=content_browsertests:ServiceWorkerVersionBrowserTest.Install* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250804 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -33 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 2 chunks +36 lines, -20 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/service_worker/embedded_worker_context_client.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/test/data/service_worker/worker.js View 1 chunk +1 line, -2 lines 0 comments Download
A + content/test/data/service_worker/worker_install_fulfilled.js View 1 chunk +3 lines, -2 lines 0 comments Download
A + content/test/data/service_worker/worker_install_rejected.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
kinuko
Finish wiring and adding some browser_tests for install and install + waitUntil. PTL
6 years, 10 months ago (2014-02-06 13:37:10 UTC) #1
alecflett
lgtm
6 years, 10 months ago (2014-02-07 19:57:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/153553008/1
6 years, 10 months ago (2014-02-07 19:58:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/153553008/1
6 years, 10 months ago (2014-02-07 22:20:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-08 02:40:46 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=260272
6 years, 10 months ago (2014-02-08 02:40:46 UTC) #6
alecflett
The CQ bit was checked by alecflett@chromium.org
6 years, 10 months ago (2014-02-12 20:07:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/153553008/1
6 years, 10 months ago (2014-02-12 20:10:41 UTC) #8
commit-bot: I haz the power
Change committed as 250804
6 years, 10 months ago (2014-02-12 22:32:45 UTC) #9
guohui
A revert of this CL has been created in https://codereview.chromium.org/147903008/ by guohui@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-13 01:17:15 UTC) #10
kinuko
It looks like fix for it (in blink) wasn't rolled yet when it landed. Let ...
6 years, 10 months ago (2014-02-13 04:04:54 UTC) #11
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 10 months ago (2014-02-13 04:05:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/153553008/1
6 years, 10 months ago (2014-02-13 04:06:18 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 04:08:27 UTC) #14
Message was sent while issue was closed. 
Change committed as 250936

Powered by Google App Engine
This is Rietveld 408576698