Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 153553008: Wire InstallFinished and add some InstallEvent.waitUntil tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_script_context.cc
diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc
index 2930ce22bd1733a3a91455cf5bf6a49c45e8b8f0..3edd887bac377321d48410a1d8ff15bd1f464713 100644
--- a/content/renderer/service_worker/service_worker_script_context.cc
+++ b/content/renderer/service_worker/service_worker_script_context.cc
@@ -48,12 +48,7 @@ void ServiceWorkerScriptContext::Send(int request_id,
void ServiceWorkerScriptContext::OnInstallEvent(
int active_version_embedded_worker_id) {
- // TODO(kinuko): Uncomment this when blink side becomes ready.
- // proxy_->dispatchInstallEvent(current_request_id_);
-
- // TODO(kinuko): this should be called asynchronously from blink side
- // when blink-side plumbing is done.
- DidHandleInstallEvent(current_request_id_);
+ proxy_->dispatchInstallEvent(current_request_id_);
}
void ServiceWorkerScriptContext::OnFetchEvent(
« no previous file with comments | « content/renderer/service_worker/embedded_worker_context_client.cc ('k') | content/test/data/service_worker/worker.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698