Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: third_party/WebKit/Source/core/dom/Range.h

Issue 1535403002: Cleanup return values in DOM Range. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Separate AUTHORS modify Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Range.h
diff --git a/third_party/WebKit/Source/core/dom/Range.h b/third_party/WebKit/Source/core/dom/Range.h
index 0a8bed0a1df604c58ae4e578a2d3e0c4ba19758f..70aee6383ce41ebfbf50432b41ef500ca6c56f69 100644
--- a/third_party/WebKit/Source/core/dom/Range.h
+++ b/third_party/WebKit/Source/core/dom/Range.h
@@ -113,8 +113,8 @@ public:
void surroundContents(PassRefPtrWillBeRawPtr<Node>, ExceptionState&);
void setStartBefore(Node*, ExceptionState& = ASSERT_NO_EXCEPTION);
- const Position startPosition() const { return m_start.toPosition(); }
- const Position endPosition() const { return m_end.toPosition(); }
+ const Position& startPosition() const { return m_start.toPosition(); }
yosin_UTC9 2016/01/05 04:32:31 We can't return const ref here at least VS2013 and
JakeYoon 2016/01/05 13:12:46 In fact, This patch is for replacing const value
+ const Position& endPosition() const { return m_end.toPosition(); }
haraken 2015/12/22 06:45:38 Why doesn't toPosition return const Position&?
void setStart(const Position&, ExceptionState& = ASSERT_NO_EXCEPTION);
void setEnd(const Position&, ExceptionState& = ASSERT_NO_EXCEPTION);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698