Chromium Code Reviews| Index: third_party/WebKit/Source/core/dom/Range.h |
| diff --git a/third_party/WebKit/Source/core/dom/Range.h b/third_party/WebKit/Source/core/dom/Range.h |
| index 0a8bed0a1df604c58ae4e578a2d3e0c4ba19758f..70aee6383ce41ebfbf50432b41ef500ca6c56f69 100644 |
| --- a/third_party/WebKit/Source/core/dom/Range.h |
| +++ b/third_party/WebKit/Source/core/dom/Range.h |
| @@ -113,8 +113,8 @@ public: |
| void surroundContents(PassRefPtrWillBeRawPtr<Node>, ExceptionState&); |
| void setStartBefore(Node*, ExceptionState& = ASSERT_NO_EXCEPTION); |
| - const Position startPosition() const { return m_start.toPosition(); } |
| - const Position endPosition() const { return m_end.toPosition(); } |
| + const Position& startPosition() const { return m_start.toPosition(); } |
|
yosin_UTC9
2016/01/05 04:32:31
We can't return const ref here at least VS2013 and
JakeYoon
2016/01/05 13:12:46
In fact, This patch is for replacing const value
|
| + const Position& endPosition() const { return m_end.toPosition(); } |
|
haraken
2015/12/22 06:45:38
Why doesn't toPosition return const Position&?
|
| void setStart(const Position&, ExceptionState& = ASSERT_NO_EXCEPTION); |
| void setEnd(const Position&, ExceptionState& = ASSERT_NO_EXCEPTION); |