Cleanup return values in DOM Range.

third_party/WebKit/Source/core/dom/Range.h

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Gunnstein Lye (gunnstein@netcom.no)
  * (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
  * (C) 2001 Peter Kelly (pmk@post.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 95 matching lines @@
 
     void setStartAfter(Node*, ExceptionState& = ASSERT_NO_EXCEPTION);
     void setEndBefore(Node*, ExceptionState& = ASSERT_NO_EXCEPTION);
     void setEndAfter(Node*, ExceptionState& = ASSERT_NO_EXCEPTION);
     void selectNode(Node*, ExceptionState& = ASSERT_NO_EXCEPTION);
     void selectNodeContents(Node*, ExceptionState&);
     static bool selectNodeContents(Node*, Position&, Position&);
     void surroundContents(PassRefPtrWillBeRawPtr<Node>, ExceptionState&);
     void setStartBefore(Node*, ExceptionState& = ASSERT_NO_EXCEPTION);
 
-    const Position startPosition() const { return m_start.toPosition(); }
-    const Position endPosition() const { return m_end.toPosition(); }
+    const Position& startPosition() const { return m_start.toPosition(); }

[yosin_UTC9, 2016/01/05 04:32:31]

We can't return const ref here at least VS2013 and VS2015. I got following error
message:

d:\src\w\cr\src\third_party\webkit\source\core\dom\range.h(116) : warning C4172:
returning address of local variable or temporary
d:\src\w\cr\src\third_party\webkit\source\core\dom\range.h(117) : warning C4172:
returning address of local variable or temporary

Can clang/gcc compile this change w/o warnings/errors?

[JakeYoon, 2016/01/05 13:12:46]

In fact, This patch is for replacing const value 
by a const ref when a member.

But startPosition function doesn't return
a member variable, So it looks like incorrect.
How do you think Yoshi@ ??

+    const Position& endPosition() const { return m_end.toPosition(); }

[haraken, 2015/12/22 06:45:38]

Why doesn't toPosition return const Position&?

     void setStart(const Position&, ExceptionState& = ASSERT_NO_EXCEPTION);
     void setEnd(const Position&, ExceptionState& = ASSERT_NO_EXCEPTION);
 
     Node* firstNode() const;
     Node* pastLastNode() const;
 
     ShadowRoot* shadowRoot() const;
 
     enum RangeInFixedPosition {
         NotFixedPosition,
@@ skipping 59 matching lines @@
 CORE_EXPORT bool areRangesEqual(const Range*, const Range*);
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::Range*);
 #endif
 
 #endif // Range_h