Issue 1534913004: Fix ContentViewCore height for fullscreen panel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1534913004: Fix ContentViewCore height for fullscreen panel (Closed)

Created:
5 years ago by mdjones

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Fix ContentViewCore height for fullscreen panel Add fullscreen checks to the ContentViewClient responsible for sizing the ContentViewCore. BUG=568616, 560130 Review URL: https://codereview.chromium.org/1537733002 Cr-Commit-Position: refs/heads/master@{#365940} (cherry picked from commit cbdf827e607ba0aeb69ea5b712f614adb6f5fc33) Committed: https://chromium.googlesource.com/chromium/src/+/a3d15b0754d6fc3612ce463f06da7b129ab8766e

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java	View		1 chunk	+14 lines, -6 lines	0 comments	Download

Total messages: 2 (1 generated)

mdjones

5 years ago (2015-12-18 01:10:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a3d15b0754d6fc3612ce463f06da7b129ab8766e.