chrome/chrome_watcher/BUILD.gn - Issue 1534903002: Split GN installer_util into one that has no strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_watcher/BUILD.gn

Issue 1534903002: Split GN installer_util into one that has no strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_watcher/BUILD.gn

diff --git a/chrome/chrome_watcher/BUILD.gn b/chrome/chrome_watcher/BUILD.gn

index f22058091549812908c3d6eb649c51ec0526e16e..bb5f52fa9d853ab19991a430af54b40970b24e58 100644

--- a/chrome/chrome_watcher/BUILD.gn

+++ b/chrome/chrome_watcher/BUILD.gn

@@ -35,7 +35,7 @@ shared_library("chrome_watcher") {

"//base",

"//base:base_static",

"//build/config/sanitizers:deps",

- "//chrome/installer/util",

+ "//chrome/installer/util:with_no_strings_some_things_wont_work",

"//components/browser_watcher",

]

ldflags = [ "/DEF:" + rebase_path("chrome_watcher.def", root_build_dir) ]

« no previous file with comments | « chrome/browser/metro_utils/BUILD.gn ('k') | chrome/installer/util/BUILD.gn » ('j') | no next file with comments »