chrome/browser/metro_utils/BUILD.gn - Issue 1534903002: Split GN installer_util into one that has no strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metro_utils/BUILD.gn

Issue 1534903002: Split GN installer_util into one that has no strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metro_utils/BUILD.gn

diff --git a/chrome/browser/metro_utils/BUILD.gn b/chrome/browser/metro_utils/BUILD.gn

index 86a28875cc8bb6787a0807467adcbb3072e01ce0..715348504d4ae924461ac1f5bb8d82865667d6e0 100644

--- a/chrome/browser/metro_utils/BUILD.gn

+++ b/chrome/browser/metro_utils/BUILD.gn

@@ -5,7 +5,11 @@

source_set("metro_utils") {

deps = [

"//base",

- "//chrome/installer/util",

+ # We use a few functions from here but don't depend on the resource

+ # strings. This target is indirectly linked into chrome.exe, so

+ # specifically doesn't want those strings.

+ "//chrome/installer/util:with_no_strings_some_things_wont_work",

]

sources = [

"metro_chrome_win.cc",

« no previous file with comments | « chrome/BUILD.gn ('k') | chrome/chrome_watcher/BUILD.gn » ('j') | no next file with comments »