Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 1534753003: [Mac] Fix regression where commands were disabled in full screen. (Closed)

Created:
5 years ago by Alexei Svitkine (slow)
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix regression where commands were disabled in full screen. This was caused by: https://codereview.chromium.org/1250403002 That CL moved where command validation happened, but the new handler wasn't hooked up to the full screen window that gets opened on 10.6. Note: The 10.6 behavior can be simulated by changing the return value of SupportsSystemFullscreen() to false. BUG=569418 TEST=On Mac OS 10.6, check that cmd-shift-F can toggle full screen back and forth. Review URL: https://codereview.chromium.org/1520283003 Cr-Commit-Position: refs/heads/master@{#365375} (cherry picked from commit 4d1e70c750dc009ce1c23e76b8c2009264dba0ef) Committed: https://chromium.googlesource.com/chromium/src/+/38b1a83423628993396862e4a843d1062c1f291a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Alexei Svitkine (slow)
5 years ago (2015-12-17 16:15:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
38b1a83423628993396862e4a843d1062c1f291a.

Powered by Google App Engine
This is Rietveld 408576698