Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1520283003: [Mac] Fix regression where commands were disabled in full screen. (Closed)

Created:
5 years ago by Alexei Svitkine (slow)
Modified:
5 years ago
Reviewers:
jackhou1, tapted
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix regression where commands were disabled in full screen. This was caused by: https://codereview.chromium.org/1250403002 That CL moved where command validation happened, but the new handler wasn't hooked up to the full screen window that gets opened on 10.6. Note: The 10.6 behavior can be simulated by changing the return value of SupportsSystemFullscreen() to false. BUG=569418 TEST=On Mac OS 10.6, check that cmd-shift-F can toggle full screen back and forth. Committed: https://crrev.com/4d1e70c750dc009ce1c23e76b8c2009264dba0ef Cr-Commit-Position: refs/heads/master@{#365375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Alexei Svitkine (slow)
5 years ago (2015-12-14 17:02:13 UTC) #2
Alexei Svitkine (slow)
+tapted as well, in case Jack is away. Whichever one of you can review this ...
5 years ago (2015-12-15 16:56:22 UTC) #4
tapted
lgtm - thanks!
5 years ago (2015-12-15 22:12:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520283003/1
5 years ago (2015-12-15 22:13:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 23:12:10 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-15 23:13:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d1e70c750dc009ce1c23e76b8c2009264dba0ef
Cr-Commit-Position: refs/heads/master@{#365375}

Powered by Google App Engine
This is Rietveld 408576698