Chromium Code Reviews
DescriptionFix a regression caused by my change to make the first run bubble window display as an inactive window.
The expectation is that we should dismiss the bubble on activities like mouse down, touch down, on the anchor
window as well.
The FirstRunBubbleCloser class now observes the native view instead of the root view as the latter does not work
if we have mouse and touch events on the RWHVA.
BUG=555416
TEST=Covered by tests FirstRunBubbleTest.CloseBubbleOnMouseDownEvent and FirstRunBubbleTest.CloseBubbleOnTouchDownEvent
Review URL: https://codereview.chromium.org/1443253004
Cr-Commit-Position: refs/heads/master@{#359902}
(cherry picked from commit 50a8b1f1eb5cf75b2fc756389cc783d33cd0934c)
Committed: https://chromium.googlesource.com/chromium/src/+/fed68834e3856c397e295290e80185c7e40306e5
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||