Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 1534653002: Fix a regression caused by my change to make the first run bubble window display as an inactive win… (Closed)

Created:
5 years ago by ananta
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Fix a regression caused by my change to make the first run bubble window display as an inactive window. The expectation is that we should dismiss the bubble on activities like mouse down, touch down, on the anchor window as well. The FirstRunBubbleCloser class now observes the native view instead of the root view as the latter does not work if we have mouse and touch events on the RWHVA. BUG=555416 TEST=Covered by tests FirstRunBubbleTest.CloseBubbleOnMouseDownEvent and FirstRunBubbleTest.CloseBubbleOnTouchDownEvent Review URL: https://codereview.chromium.org/1443253004 Cr-Commit-Position: refs/heads/master@{#359902} (cherry picked from commit 50a8b1f1eb5cf75b2fc756389cc783d33cd0934c) Committed: https://chromium.googlesource.com/chromium/src/+/fed68834e3856c397e295290e80185c7e40306e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -65 lines) Patch
M chrome/browser/ui/views/first_run_bubble.h View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 2 chunks +31 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble_unittest.cc View 4 chunks +71 lines, -49 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ananta
5 years ago (2015-12-17 01:21:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fed68834e3856c397e295290e80185c7e40306e5 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698