Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1443253004: Fix a regression caused by my change to make the first run bubble window display as an inactive win… (Closed)

Created:
5 years, 1 month ago by ananta
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a regression caused by my change to make the first run bubble window display as an inactive window. The expectation is that we should dismiss the bubble on activities like mouse down, touch down, on the anchor window as well. The FirstRunBubbleCloser class now observes the native view instead of the root view as the latter does not work if we have mouse and touch events on the RWHVA. BUG=555416 TEST=Covered by tests FirstRunBubbleTest.CloseBubbleOnMouseDownEvent and FirstRunBubbleTest.CloseBubbleOnTouchDownEvent Committed: https://crrev.com/50a8b1f1eb5cf75b2fc756389cc783d33cd0934c Cr-Commit-Position: refs/heads/master@{#359902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -65 lines) Patch
M chrome/browser/ui/views/first_run_bubble.h View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 2 chunks +31 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble_unittest.cc View 4 chunks +71 lines, -49 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
ananta
5 years, 1 month ago (2015-11-14 02:53:50 UTC) #2
sky
LGTM
5 years, 1 month ago (2015-11-14 15:32:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1443253004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1443253004/1
5 years, 1 month ago (2015-11-16 19:58:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 20:38:15 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 20:39:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50a8b1f1eb5cf75b2fc756389cc783d33cd0934c
Cr-Commit-Position: refs/heads/master@{#359902}

Powered by Google App Engine
This is Rietveld 408576698